Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [#1398] Add support for iframe srcdoc #1399

Merged
merged 3 commits into from May 6, 2024

Conversation

jeffwcx
Copy link
Contributor

@jeffwcx jeffwcx commented Apr 10, 2024

Implement the iframe srcdoc attribute, which should operate similarly to the src attribute but with higher priority, without the need to initiate a fetch request.

Also, I have fixed several bugs:

  • When remove the src or srcdoc attributes, the iframe should be reloaded.
  • For non-cross-domain iframes, after being connected to the Document, their contentWindow’s parent/top properties should not be null.

References:

@jeffwcx
Copy link
Contributor Author

jeffwcx commented Apr 25, 2024

@capricorn86 can you take a look?

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeffwcx for your contribution! 🌟

I've added a fix to isolate the implementation to the iframe implementation, as "srcdoc" is not really related to navigating a Browser frame.

@capricorn86 capricorn86 merged commit a289408 into capricorn86:master May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants