URL constructor is missing 'base' option

[silverwind]

The URL constructor at

happy-dom/packages/happy-dom/src/location/URL.ts

Line 23 in 57a8d33

constructor(url?: string) {

does not support the second form of the URL constructor which takes a base url:

new URL(url)
new URL(url, base)

Quick test:

# expected
> new URL('', 'https://example.com').pathname
'/'
# actual
> new URL('', 'https://example.com').pathname
''

[silverwind]

BTW I think the URL implementation could be sourced from https://github.com/jsdom/whatwg-url, which is pretty much the reference implementation.

[Mas0nShi]

Hi! @silverwind😊. Thank you for your feedback. jsdom/whatwg-urlso slow because it follows the standard exactly. I think we can test with native module node:url. yes, Im trying do it.

#521
#520 (comment)

[silverwind]

URL in node:url is to my knowledge also a complete copy of jsdom/whatwg-url. If you want to marry happy-dom to node, it might be feasible to use that instead, but it's going to be equally "slow" :)

Oh, any you shouldn't forget URLSearchParams which is also provided by jsdom/whatwg-url.

[Mas0nShi]

No, I don't approve.
you can test the performance of both.

my test unit.

const wg = require("whatwg-url");

console.time("whatwg-url");
for (let i = 0; i < 1000000; i++) {
	new wg.URL('', 'https://example.com');
}
console.timeEnd("whatwg-url");

console.time("node:url");
for (let i = 0; i < 1000000; i++) {
	new URL('', 'https://example.com');
}
console.timeEnd("node:url");

test parse 1 million times, whatwg-url needs about 11s but node:url only about 1s.

[silverwind]

Interesting, they must've done some additional optimizations not present in jsdom/whatwg-url.

[Mas0nShi]

Maybe. I don't look closely, you can see the implementation of node:url at https://github.com/nodejs/node/blob/v18.7.0/lib/url.js

[silverwind]

It's in https://github.com/nodejs/node/blob/v18.7.0/lib/internal/url.js. Definitely contains various low-level optimizations. Maybe as a solution, you could check if running on node, use node:url there, otherwise fall back to jsdom/whatwg-url. That would make it compatibly with other JS runtimes as well, like Deno.

[hugo-dlb]

After a lot of debugging, I stumbled upon the same issue. In my case I was trying to replace jsdom by happydom for our tests but this is not possible because of this issue. MSW is relying on this constructor (and I'm sure many other libraries do): https://github.com/mswjs/interceptors/blob/main/src/utils/getUrlByRequestOptions.ts#L91

It would be awesome if happy-dom could add this. :)

[shayneo]

Found my way here via the vitest 0.25.1 issues. Any new thoughts on supporting the new URL(url, base) constructor? Would a PR be welcome?

[capricorn86]

Hi @shayneo! 🙂

Great that you want to contribute. However, I believe that me and @Mas0nShi are already working on a PR related to this, which should solve it.

We will remove the custom URL implementation and replace it with Nodes.

You can see the change here:
https://github.com/capricorn86/happy-dom/pull/520/files#diff-962b53d12390f23f537f3d9b4d96d382fc950b0d4e7464cfefcbf3450a72f0c5R43

[shayneo]

Hi @shayneo! 🙂

Great that you want to contribute. However, I believe that me and @Mas0nShi are already working on a PR related to this, which should solve it.

We will remove the custom URL implementation and replace it with Nodes.

You can see the change here: https://github.com/capricorn86/happy-dom/pull/520/files#diff-962b53d12390f23f537f3d9b4d96d382fc950b0d4e7464cfefcbf3450a72f0c5R43

Thanks for the quick reply @capricorn86! Looks like this is well underway.

[capricorn86]

We have now fixed this by using the native url module 🙂

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v7.8.0