Slight URL parsing update

[DoctorMalice]

I would like to be able to set the window.location.href value to a value that uses any protocol and have it returned as expected. Currently I have a test like the following that fails:

window.location.href = 'git://test'
expect(window.location.href).toEqual('git://test')

The actual value is //git://test

I believe the reason is because the url parser only understands http and https as protocols (given the regex in the URL.ts file):

const URL_REGEXP = /(https?:)\/\/([-a-zA-Z0-9@:%._\+~#=]{2,256}[a-z]{2,6})(:[0-9]*)?([-a-zA-Z0-9@:%_\+.~c&//=]*)(\?[^#]*)?(#.*)?/;

So when the url is retrieved, '//' is prepended due to there being no protocol in this code:

public get href(): string {
  const credentials = this.username ? `${this.username}:${this.password}@` : '';
  return this.protocol + '//' + credentials + this.host + this.pathname + this.search + this.hash;
}

I'm not a big picture kind of person, so I may not be thinking of the issues associated with the following change, but the url (and any url with a custom protocol) is parsed properly with the following regex:

const URL_REGEXP = /(.+:)\/\/([-a-zA-Z0-9@:%._\+~#=]{2,256}[a-z]{2,6})(:[0-9]*)?([-a-zA-Z0-9@:%_\+.~c&//=]*)(\?[^#]*)?(#.*)?/;

An alternative solution may be only prepending the '//' when protocol is defined, but that may open up issues with protocol relative URLs.

[Mas0nShi]

Duplicate of #401 #521 #569

Hi, @DoctorMalice, It's has been solved in #520. (:
but this is a complex PR and therefore probably won't merge upstream anytime soon.

[capricorn86]

Thanks for reporting @DoctorMalice! 🙂

We have now fixed this by using the native url module.

You can read more about the release here:
https://github.com/capricorn86/happy-dom/releases/tag/v7.8.0