Merge pull request #814 from btea/task/813-unset-previous-cookie

#813@patch: Unset previous cookie.
capricorn86 · Apr 4, 2023 · 959317f · 959317f
2 parents c0d06c1 + 6a05edb
commit 959317f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/packages/happy-dom/src/cookie/Cookie.ts b/packages/happy-dom/src/cookie/Cookie.ts
@@ -35,7 +35,7 @@ export default class Cookie {
 		this.key = match[1].trim();
 		this.value = match[2];
 		// Set key is empty if match[2] is undefined.
-		if (!match[2]) {
+		if (!match[2] && parts[0][this.key.length] !== '=') {
 			this.value = this.key;
 			this.key = '';
 		}

diff --git a/packages/happy-dom/test/nodes/document/Document.test.ts b/packages/happy-dom/test/nodes/document/Document.test.ts
@@ -218,6 +218,13 @@ describe('Document', () => {
 			expect(document.cookie).toBe('');
 		});
 
+		it('Unset previous cookie.', () => {
+			document.cookie = 'name=Dave; expires=Thu, 01 Jan 2025 00:00:00 GMT;';
+			expect(document.cookie).toBe('name=Dave');
+			document.cookie = 'name=; expires=Thu, 01 Jan 1970 00:00:00 GMT;';
+			expect(document.cookie).toBe('');
+		});
+
 		it('Removes a previously defined cookie if "expires" is in the past, but treats cookies with no value set differently from cookies with a value.', () => {
 			document.cookie = 'name=value1';
 			document.cookie = 'name';