Merge pull request #649 from itutto/#648-option-element-value-patch

#648@patch: OptionElement.value returns `textContent` as fallback.
capricorn86 · Nov 8, 2022 · 1a21ed7 · 1a21ed7
2 parents 62e2920 + f543b06
commit 1a21ed7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/happy-dom/src/nodes/html-option-element/HTMLOptionElement.ts b/packages/happy-dom/src/nodes/html-option-element/HTMLOptionElement.ts
@@ -109,7 +109,7 @@ export default class HTMLOptionElement extends HTMLElement implements IHTMLOptio
 	 * @returns Value.
 	 */
 	public get value(): string {
-		return this.getAttributeNS(null, 'value') || '';
+		return this.getAttributeNS(null, 'value') || this.textContent;
 	}
 
 	/**

diff --git a/packages/happy-dom/test/nodes/html-option-element/HTMLOptionElement.test.ts b/packages/happy-dom/test/nodes/html-option-element/HTMLOptionElement.test.ts
@@ -25,6 +25,12 @@ describe('HTMLOptionElement', () => {
 			element.setAttribute('value', 'VALUE');
 			expect(element.value).toBe('VALUE');
 		});
+
+		it('Returns the text IDL value if no attribute is present.', () => {
+			element.removeAttribute('value');
+			element.textContent = 'TEXT VALUE';
+			expect(element.value).toBe('TEXT VALUE');
+		});
 	});
 
 	describe('set value()', () => {