Move zenhack.net/go/util into go-capnp repository #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...just for 100% test coverage; this is maybe a little gratuitous but meh.
See comment.
See the doc.
This is basically a go-accented "Result" type.
...for more complex synchronization patterns than can be accommodated by With, which unfortunately go-capnp has a few of.
...which I found myself needing.
Inspired by the way Client refcounting works in go-capnp. Needs docs & tests still.
I'm not quite sure how the interfaces fit in yet, and Releaser feels wrong given Ref takes a separate callback. Easier to add than remove.
These feel more natural to me, despite being redundant with the package names.
...by adding strings indicating what we're checking.
Now at 100%.
Right now just contains a Queue type that is based on the releaseList type in go-capnp's rpc package, factored out for use elsewhere. WIP; needs docs & tests still.
See the comment. I'm finding I need something like this for cases where the release function needs to operate on a value at a particular address.
...I find myself writing these three lines of code often enough when debugging that it seemed worth doing this once and for all.
Closed
lthibault
approved these changes
Oct 7, 2023
davidhubbard
added a commit
to davidhubbard/go-capnp-46
that referenced
this pull request
Oct 9, 2023
The top-level README.md file for https://github.com/capnproto/go-capnp was accidentally deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the code from https://zenhack.net/go/util into a package called
util. By merging instead of copying @zenhack's commit history is preserved.