RegisterSchema once per golang package #490 #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhubbard
commented
Sep 6, 2023
davidhubbard
force-pushed
the
issue-490
branch
from
6afcb98
to
2eb80da
Compare
lthibault
requested changes
Sep 6, 2023
davidhubbard
force-pushed
the
issue-490
branch
from
2eb80da
to
13494c5
Compare
Fixes capnproto#490 by only generating one `RegisterSchema()` function per `$Go.package()`. For example, the unit tests persistent-simple.capnp and persistent-samepkg.capnp now both have the annotation: `$Go.package("persistent_simple");` Their generated go code thus starts with: `package persistent_simple` but only one of them will include a `RegisterSchema()`. Note: if `capnp` is invoked with only one .capnp file at a time on its command line, `capnpc-go` will not detect any *other* .capnp files that might have the same $Go.package. For that use case, the user might be able to cope by running `capnpc -o - persistent-simple.capnp | capnpc-go --forceschemasalways` and editing the generated code to rename all but one `RegisterSchema()` and add calls to the renamed code inside the one remainig `RegisterSchema()`... though that is not a supported solution. e.g. Use this: `capnpc -o go persistent-simple.capnp persistent-samepkg.capnp` Because the following will fail to compile due to duplicate `RegisterSchema()` definitions: ``` capnpc -o go persistent-simple.capnp capnpc -o go persistent-samepkg.capnp ```
davidhubbard
force-pushed
the
issue-490
branch
from
13494c5
to
e027dbb
Compare
lthibault
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #490 by only generating one
RegisterSchema()function per$Go.package().For example, the unit tests persistent-simple.capnp and persistent-samepkg.capnp now both have the annotation:
$Go.package("persistent_simple");Their generated go code thus starts with:
package persistent_simplebut only one of them will include a
RegisterSchema().