Skip to content

Commit

Permalink
Exclude danger to fix Ruby 2.0.0 CI error (#2030)
Browse files Browse the repository at this point in the history
danger no longer installs cleanly on Ruby 2.0.0. Our CI only runs danger
on Ruby 2.5, so there is no reason to install it for older versions.

Fixes #2029
  • Loading branch information
mattbrictson committed Aug 29, 2019
1 parent 28205f4 commit a7ae1a6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
5 changes: 5 additions & 0 deletions Gemfile
Expand Up @@ -30,3 +30,8 @@ end
if Gem::Requirement.new("< 2.1").satisfied_by?(Gem::Version.new(RUBY_VERSION))
gem "i18n", "< 1.3.0"
end

# We only run danger once on a new-ish ruby; no need to install it otherwise
if Gem::Requirement.new("> 2.4").satisfied_by?(Gem::Version.new(RUBY_VERSION))
gem "danger"
end
1 change: 0 additions & 1 deletion capistrano.gemspec
Expand Up @@ -28,7 +28,6 @@ Gem::Specification.new do |gem|
gem.add_dependency "rake", ">= 10.0.0"
gem.add_dependency "sshkit", ">= 1.9.0"

gem.add_development_dependency "danger"
gem.add_development_dependency "mocha"
gem.add_development_dependency "rspec"
gem.add_development_dependency "rubocop", "0.48.1"
Expand Down

0 comments on commit a7ae1a6

Please sign in to comment.