Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(errors): improve error messages #38

Merged
merged 10 commits into from Jul 29, 2020
Merged

Conversation

JCustin
Copy link
Contributor

@JCustin JCustin commented Jul 28, 2020

Rewrote error messages with a consistent structure to explain said errors, as well as a transition to the administrator's contact information. The administrator's information will needed to be plugged in by a more knowledgeable contributor.

Note that because I am not familiar with Go, some of the error messages may have an incorrect explanation for the error. I encourage a double check on the terminology and logic explained in my messages. If there are any errors, please correct the terminology and logic while retaining the sentence structure.

Rewrote error messages with a consistent structure to explain said errors, as well as a transition to the administrator's contact information. The administrator's information will needed to be plugged in by a more knowledgeable contributor.

Note that because I am not familiar with Go, some of the error messages may have an incorrect explanation for the error. I encourage a double check on the terminology and logic explained in my messages. If there are any errors, please correct the terminology and logic while retaining the sentence structure.
@fforootd fforootd added the enhancement New feature or request label Jul 28, 2020
@fforootd fforootd changed the title Update authrequest.go fix(errors): improve error messages Jul 28, 2020
pkg/op/authrequest.go Outdated Show resolved Hide resolved
pkg/op/authrequest.go Outdated Show resolved Hide resolved
pkg/op/authrequest.go Outdated Show resolved Hide resolved
pkg/op/authrequest.go Outdated Show resolved Hide resolved
pkg/op/authrequest.go Outdated Show resolved Hide resolved
pkg/op/authrequest.go Outdated Show resolved Hide resolved
pkg/op/authrequest.go Outdated Show resolved Hide resolved
pkg/op/authrequest.go Outdated Show resolved Hide resolved
pkg/op/authrequest.go Outdated Show resolved Hide resolved
JCustin and others added 9 commits July 28, 2020 13:24
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
Co-authored-by: Fabi <38692350+fgerschwiler@users.noreply.github.com>
@hifabienne hifabienne merged commit 665cfb3 into zitadel:master Jul 29, 2020
@fforootd fforootd mentioned this pull request Jul 29, 2020
@github-actions
Copy link

🎉 This PR is included in version 0.6.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants