Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix "RangeError: Maximum call stack size exceeded" #1514

Merged
merged 2 commits into from Feb 16, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/internal/eachOfLimit.js
Expand Up @@ -15,6 +15,7 @@ export default function _eachOfLimit(limit) {
var nextElem = iterator(obj);
var done = false;
var running = 0;
var looping = false;

function iterateeCallback(err, value) {
running -= 1;
Expand All @@ -26,12 +27,13 @@ export default function _eachOfLimit(limit) {
done = true;
return callback(null);
}
else {
else if (!looping) {
replenish();
}
}

function replenish () {
looping = true;
while (running < limit && !done) {
var elem = nextElem();
if (elem === null) {
Expand All @@ -44,6 +46,7 @@ export default function _eachOfLimit(limit) {
running += 1;
iteratee(elem.value, elem.key, onlyOnce(iterateeCallback));
}
looping = false;
}

replenish();
Expand Down
60 changes: 60 additions & 0 deletions mocha_test/eachOf.js
Expand Up @@ -43,6 +43,30 @@ describe("eachOf", function() {
});
});

it('forEachOf no call stack size exceed error', function(done) {
var obj = {};
var len = 3000;
var args = new Array(len * 2);
var expected = new Array(len * 2);

for (var i = 0; i < len; i++) {
obj["a" + i] = i;
expected[2 * i] = "a" + i;
expected[2 * i + 1] = i;
}

async.forEachOf(obj, function(value, key, callback) {
var index = parseInt(key.slice(1), 10);
args[2 * index] = key;
args[2 * index + 1] = value;
callback();
}, function(err) {
assert(err === null, err + " passed instead of 'null'");
expect(args).to.eql(expected);
done();
});
});

it('forEachOf - instant resolver', function(done) {
var args = [];
async.forEachOf({ a: 1, b: 2 }, function(x, k, cb) {
Expand Down Expand Up @@ -139,6 +163,30 @@ describe("eachOf", function() {
});
});

it('forEachOfSeries no call stack size exceed error', function(done) {
var obj = {};
var len = 3000;
var args = new Array(len * 2);
var expected = new Array(len * 2);

for (var i = 0; i < len; i++) {
obj["a" + i] = i;
expected[2 * i] = "a" + i;
expected[2 * i + 1] = i;
}

async.forEachOfSeries(obj, function(value, key, callback) {
var index = parseInt(key.slice(1), 10);
args[2 * index] = key;
args[2 * index + 1] = value;
callback();
}, function(err) {
assert(err === null, err + " passed instead of 'null'");
expect(args).to.eql(expected);
done();
});
});

it('forEachOfSeries empty object', function(done) {
async.forEachOfSeries({}, function(x, callback){
assert(false, 'iteratee should not be called');
Expand Down Expand Up @@ -274,6 +322,18 @@ describe("eachOf", function() {
setTimeout(done, 25);
});

it('forEachOfLimit no call stack size exceed error', function(done) {
var count = 0;
async.forEachOfLimit(_.range(1024 * 1024), Infinity, function(x, i, callback){
count++;
callback();
}, function(err){
if (err) throw err;
expect(count).to.equal(1024 * 1024);
done();
});
});

it('forEachOfLimit error', function(done) {
var obj = { a: 1, b: 2, c: 3, d: 4, e: 5 };
var call_order = [];
Expand Down