Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[asyncify] Make errors in callbacks throw globally #1408

Merged
merged 1 commit into from Apr 22, 2017
Merged

[asyncify] Make errors in callbacks throw globally #1408

merged 1 commit into from Apr 22, 2017

Commits on Apr 19, 2017

  1. [asyncify] Make errors in callbacks throw globally 

    If asyncify wraps a function returning promises, the callback will be executed as part of the promise’s `.then()` method.
This means that any error thrown from that method will be silenced, and lead to a “unhandled promise rejection” warning in modern engines.

Usually, we want these errors to be visible, and even crash the process.
    @davidaurelio
    davidaurelio committed Apr 19, 2017
    Copy the full SHA
    d45fac1 View commit details
    Browse the repository at this point in the history