Short circuit loops completely for some,every,detect when ready #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megawac
force-pushed
the
break-tester-loops
branch
from
cbae8be
to
509e3a7
Compare
|
Looks good to me |
megawac
force-pushed
the
break-tester-loops
branch
from
096e474
to
74c01fe
Compare
aearly
reviewed
Oct 17, 2016
| let calls = 0; | ||
| async.everyLimit(arr, 100, function(data, cb) { | ||
| calls += 1; | ||
| async.setImmediate(_.partial(cb, null, false)); |
There was a problem hiding this comment.
FYI, setImmediate will partially apply params for you, no need for _.partial
There was a problem hiding this comment.
I thought our implementation didn't (though didn't check :))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to short circuit
eachLimitandeachSeriesloops internally. Break loops when value is determined for some, every and detect/findFixes #1293