Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding howto guides for CVEs/USN #3116

Open
wants to merge 2 commits into
base: docs
Choose a base branch
from
Open

docs: Adding howto guides for CVEs/USN #3116

wants to merge 2 commits into from

Conversation

dheyay
Copy link
Contributor

@dheyay dheyay commented May 16, 2024

Why is this needed?

This PR solves all of our problems because it adds the following guides to documentation

- How to resolve a given CVE/USN?
- How to know if a system is affected by a CVE/USN?
- How to know if a system is affected by a list of CVE/USN?

Test Steps

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

@github-actions github-actions bot added the docs label May 16, 2024
@dheyay dheyay marked this pull request as draft May 17, 2024 11:41
@dheyay dheyay force-pushed the cve-howto-guides branch 2 times, most recently from ac7a80f to 69ed0e0 Compare May 28, 2024 17:19
@dheyay dheyay requested a review from s-makin May 28, 2024 17:32
@dheyay
Copy link
Contributor Author

dheyay commented May 28, 2024

Directly dependent on:

These need to be reviewed/approved before the howto guides are approved.

@dheyay dheyay marked this pull request as ready for review May 28, 2024 19:23
Copy link
Contributor

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice changes overall :) if you want to have a chat about any of the suggestions lmk, happy to rubberduck on this if it helps

@@ -104,10 +104,15 @@ Ubuntu Pro Client for Clouds
Create a customised Cloud Ubuntu Pro image <howtoguides/create_pro_golden_image>
Cloud Ubuntu Pro images with FIPS updates <howtoguides/create_a_fips_updates_pro_cloud_image>

Fixing multiple CVEs
====================
CVE/USN resolution
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With headers (especially in how-tos) I tend to try and use language that feels a bit more "active" because it reflects the sort of keywords users might use when they're searching the docs for something. In this case I'd recommend switching this to something more like "Resolve CVEs and USNs" or "Fixing CVEs and USNs". I'll let you have a think and decide what wording you want to use, I would just always avoid using words ending in "-tion" because they don't come up in searches very often.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think of it, makes much more sense to have something like "Fixing multiple CVEs and USNs"

docs/howtoguides.rst Outdated Show resolved Hide resolved
docs/howtoguides.rst Outdated Show resolved Hide resolved
docs/howtoguides.rst Outdated Show resolved Hide resolved
docs/howtoguides/how_to_know_if_system_affected_by_cve.rst Outdated Show resolved Hide resolved
docs/howtoguides/how_to_know_if_system_affected_by_cve.rst Outdated Show resolved Hide resolved
This is not the only scenario where you might want to use ``pro fix``. To find out about the other situations where it can be useful, as well as which options can be used to give you greater control over the command, you can refer to the following guides:

* In :ref:`Understanding scenarios encountered when using pro fix to solve a CVE/USN <pro-fix-howto>` you can continue learning more about the different scenarios you might encounter and understand the different outputs you will find.
* :ref:`How do I know what the pro fix command would change? <pro-fix-dry-run>` will show you how to use ``pro fix`` in ``--dry-run`` mode to safely simulate the changes before they're applied.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now wondering - did we not already show how to do that in this page? Do we need to combine pages?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so too, these two pages overlap in the information presented but the main difference I think from a user point of view is what the information presented represents. In one case it is for a user who is planning to use the fix command and wants to know what will change, on the other hand, the current added page let's the user check if the CVE affects their system or not.

It is basically the same thing but packaged differently for the ease of reading. let me know if you think we should actually just merge these into one. However, I think having these two guides as different pages answer different questions (I don't know how feasible it is to have both of them though}

docs/howtoguides/how_to_resolve_given_cve.rst Outdated Show resolved Hide resolved
docs/howtoguides/how_to_resolve_given_cve.rst Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants