drop support for beta functionality #3107
Conversation
The Pro client doesn't support any beta services at the moment. Additionally, we want to update our beta service logic for the next beta service we support. Due to that, we are removing the current code for beta support. However, we are keeping the beta related CLI entrypoints for compatibility reasons.
|
Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference) GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references) Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references) Documentation: The changes in this PR do not require documentation changes. 👍 this comment to confirm that this is correct. |
| @@ -281,7 +281,7 @@ Feature: Enable command behaviour when attached to an Ubuntu Pro subscription | |||
| """ | |||
| This command must be run as root (try using sudo). | |||
| """ | |||
| And I verify that running `pro enable esm-apps --beta` `with sudo` exits `1` | |||
There was a problem hiding this comment.
There is one test ( features/attached_enable.feature:177 ) where the --beta flag is kept. I don't know if that was intentional, but please keep it there so we are sure the flag is not breaking anything.
There was a problem hiding this comment.
Yes, that was intentional due to the reason you mentioned.
I am also not removing mentions of the allow_beta support through the config file, so we can also remember it in the future
Why is this needed?
The Pro client doesn't support any beta services at the moment. Additionally, we want to update our beta service logic for the next beta service we support. Due to that, we are removing the current code for beta support. However, we are keeping the beta related CLI entrypoints for compatibility reasons.
Test Steps
Verify that none of our tests are impacted by this
Checklist
Does this PR require extra reviews?