Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: create pr and release checklist comment actions (SC-1234) #3104

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

orndorffgrant
Copy link
Collaborator

@orndorffgrant orndorffgrant commented May 8, 2024

Why is this needed?

This revamps our PR checks

  • moves checklists out of PR description into bot-maintained comment
  • fails action if bug-refs aren't confirmed or checklist items aren't completed
  • moves translation template update requirement to release time

There is an extra commit here to give the action some sample data and to prevent other actions from running on this PR. We must remove that commit before merging.

Test Steps

Play with the checklist comment checkboxes and use the checkbox at the bottom of this description to re-run the actions. See how if the checklist is not properly filled out then the action fails.


  • (un)check this to re-run the checklist action

Copy link

github-actions bot commented May 8, 2024

PR Checklist

How to use this checklist

How to use this checklist

PR Author

For each section, check a box when it is true.
Uncheck a box if it becomes un-true.
Then check the box at the bottom of the PR description to re-run the action that creates this checklist.
The action that creates and updates this comment will retain your edits.
The action will fail if the checklist is not completed.

PR Reviewer

Check that the PR checklist action did not fail.
Double check that the author filled out the checklist accurately.
If you disagree with a checklist item, start a conversation.
For example, the author may say they don't think integration tests are necessary, but you may disagree.

Bug References

Confirm

  • I've properly referenced all bugs that this PR fixes
How to properly reference fixed bugs
  • If this PR is related to a Jira item, include an SC-1234 reference in the PR title
  • If this PR is fixes a GitHub issue, include a Fixes: #1234 reference in the commit that fixes the issue
  • If this PR is fixes a Launchpad bug, include a LP: #12345678 reference in the commit that fixes the issue

Test Updates

Unit Tests

  • I have updated or added any unit tests accordingly
  • No unit test changes are necessary for this change

Integration Tests

  • I have updated or added any integration tests accordingly
  • No integration test changes are necessary for this change

Documentation

  • Changes here need to be documented and I have referenced the docs PR in the description
  • No documentation updates are necessary for this change

Does this PR require review from someone outside the core ubuntu-pro-client team?

  • Yes, and I have requested those reviews via GitHub
  • No

@orndorffgrant orndorffgrant changed the title wip: pr-process test wip: pr-process test (SC-1234) May 9, 2024
Copy link

github-actions bot commented May 10, 2024

Release Checklist

Bug References

Included in changelog

Fixed but not in changelog

Confirm

  • I've properly referenced all worthy bugs in the changelog

@orndorffgrant orndorffgrant changed the title wip: pr-process test (SC-1234) ci: create pr and release checklist comment actions (SC-1234) May 10, 2024
@orndorffgrant orndorffgrant marked this pull request as ready for review May 10, 2024 15:18
@orndorffgrant orndorffgrant changed the base branch from next-v33 to main June 6, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant