Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Add service to detect clones on boot #3098

Open
wants to merge 1 commit into
base: next-v33
Choose a base branch
from

Conversation

dheyay
Copy link
Contributor

@dheyay dheyay commented May 1, 2024

Fixes: #3068

Why is this needed?

This PR solves all of our problems because...

Test Steps

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

Copy link

github-actions bot commented May 1, 2024

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues:

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

@lucasmoura
Copy link
Contributor

@dheyay @orndorffgrant I wonder if we should instead reuse the ua-reboot-cmds for this. Even though this service requires a marker file to exist in order to run, I think we can create that marker file whenever we attach the machine. In that sense, a clone would also carry that marker file with it.

The downside of this approach is that we will now execute this service on every reboot of an attached machine. We could create another marker file to show that we should only run the metering part of the service, but this might be adding to much complexity to the service.

So let me know if we should further discuss this idea.

@orndorffgrant
Copy link
Collaborator

Upon reviewing I had yet another idea: we could store jobs-status.json in /run which would make just the normal timer (with OnStartupSec=1min) execute all jobs once on startup.
We can discuss more when we have time (in madrid or after)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: clones not noticed right away
3 participants