-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update messages for livepatch #3076
Conversation
Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference) GitHub Issues: Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references) Documentation: The changes in this PR do not require documentation changes. 👍 this comment to confirm that this is correct. |
🌎 This PR changes translatable messages. 🌏 Please select which scenarios apply. For further explanation, please read our policy on message changes.
|
Existing messages are updated to use the word "coverage" instead of "support" which currently implies a relation to other means of support e.g "phone support", etc. |
8f6fc2b
to
e0e10aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you also update LIVEPATCH_KERNEL_NOT_SUPPORTED_DESCRIPTION
, LIVEPATCH_KERNEL_NOT_SUPPORTED_UNATTACHED
, LIVEPATCH_LTS_REBOOT_REQUIRED
, and REALTIME_LIVEPATCH_INCOMPATIBLE
for the same reason?
44e5f93
to
72725b8
Compare
Updated @orndorffgrant |
Looks like the translations files need to be updated. Also, please keep the po file updates in a separate commit. Something like this should do it.
|
79005cc
to
5801fb4
Compare
The kernel related livepatch messages have been updated to use the word coverage instead of support. Fixes: #3063
5801fb4
to
50795da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just wait for CI before merging it
Fixes: #3063
Why is this needed?
This PR solves all of our problems because...
Test Steps
Checklist
Does this PR require extra reviews?