Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messages for livepatch #3076

Merged
merged 2 commits into from
May 20, 2024
Merged

Conversation

dheyay
Copy link
Contributor

@dheyay dheyay commented Apr 23, 2024

Fixes: #3063

Why is this needed?

This PR solves all of our problems because...

Test Steps

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

Copy link

github-actions bot commented Apr 23, 2024

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues:

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

Copy link

github-actions bot commented Apr 23, 2024

🌎 This PR changes translatable messages. 🌏

Please select which scenarios apply. For further explanation, please read our policy on message changes.

  • New messages are being added.
    • We will ask translators to take a look and add translations if they have time, but it will not block this PR.
  • Existing messages are being changed.
    • ⚠️ Please add a comment with justification of why messages are being altered.
    • If the changes are trivial (e.g. a typo fix), then translations must be preserved.
    • If the changes are substantial, then we will ask translators to take a look and update translations if they have time, but it will not block this PR.
  • Existing messages are being deleted.
    • No special action needed.

@dheyay
Copy link
Contributor Author

dheyay commented Apr 23, 2024

🌎 This PR changes translatable messages. 🌏

Please select which scenarios apply. For further explanation, please read our policy on message changes.

* [ ]  New messages are being added.
  
  * We will ask translators to take a look and add translations if they have time, but it will not block this PR.

* [x]  Existing messages are being changed.
  
  * ⚠️ Please add a comment with justification of why messages are being altered.
  * If the changes are trivial (e.g. a typo fix), then translations must be preserved.
  * If the changes are substantial, then we will ask translators to take a look and update translations if they have time, but it will not block this PR.

* [ ]  Existing messages are being deleted.
  
  * No special action needed.

Existing messages are updated to use the word "coverage" instead of "support" which currently implies a relation to other means of support e.g "phone support", etc.

@dheyay dheyay force-pushed the livepatch-message-update branch from 8f6fc2b to e0e10aa Compare May 3, 2024 16:34
Copy link
Collaborator

@orndorffgrant orndorffgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you also update LIVEPATCH_KERNEL_NOT_SUPPORTED_DESCRIPTION, LIVEPATCH_KERNEL_NOT_SUPPORTED_UNATTACHED, LIVEPATCH_LTS_REBOOT_REQUIRED, and REALTIME_LIVEPATCH_INCOMPATIBLE for the same reason?

@dheyay dheyay force-pushed the livepatch-message-update branch 2 times, most recently from 44e5f93 to 72725b8 Compare May 3, 2024 20:11
@dheyay
Copy link
Contributor Author

dheyay commented May 3, 2024

Updated @orndorffgrant

@orndorffgrant
Copy link
Collaborator

Looks like the translations files need to be updated. Also, please keep the po file updates in a separate commit. Something like this should do it.

git reset HEAD~1
git add features uaclient/messages
git commit
./tools/update-pos.sh
git add debian/po
git commit -m "update-pos"

@dheyay dheyay force-pushed the livepatch-message-update branch 4 times, most recently from 79005cc to 5801fb4 Compare May 14, 2024 12:20
The kernel related livepatch messages have been updated to use the word coverage instead of support.
Fixes: #3063
Copy link
Contributor

@lucasmoura lucasmoura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just wait for CI before merging it

@orndorffgrant orndorffgrant merged commit d369481 into next-v33 May 20, 2024
20 of 24 checks passed
@orndorffgrant orndorffgrant deleted the livepatch-message-update branch May 20, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: livepatch say "covered" not "supported"
3 participants