Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt: better ux on lock held #3017

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

apt: better ux on lock held #3017

wants to merge 3 commits into from

Conversation

renanrodrigo
Copy link
Member

Why is this needed?

This PR solves all of our problems because it will improve the experience users have with apt locks being held.

This is blocked on the Progress Reporting implementation, because it would duplicate logic to identify CLI calls unnecessarily.

Test Steps

n/a

Checklist

  • I have updated or added any unit tests accordingly
  • I have updated or added any integration tests accordingly
  • Changes here need to be documented, and this was done in:

Does this PR require extra reviews?

  • Yes
  • No

Look only for the particular string that mentions locks in the error,
without binding it to a file name. Besides the dpkg lock, the lists lock
or the frontend lock may be being held.

Signed-off-by: Renan Rodrigo <renanrodrigo@canonical.com>
Signed-off-by: Renan Rodrigo <renanrodrigo@canonical.com>
Signed-off-by: Renan Rodrigo <renanrodrigo@canonical.com>
Copy link

Jira: This PR is not related to a Jira item. (The PR title does not include a SC-#### reference)

GitHub Issues: No GitHub issues are fixed by this PR. (No commits have Fixes: #### references)

Launchpad Bugs: No Launchpad bugs are fixed by this PR. (No commits have LP: #### references)

Documentation: The changes in this PR do not require documentation changes.

👍 this comment to confirm that this is correct.

@renanrodrigo
Copy link
Member Author

This aims at #2284, and is now waiting on a good time to move forward

@orndorffgrant orndorffgrant changed the base branch from main to next-v33 April 10, 2024 00:33
@renanrodrigo renanrodrigo changed the base branch from next-v33 to main June 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant