Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: migrate to ruff #374

Merged
merged 8 commits into from
May 20, 2024
Merged

refactor: migrate to ruff #374

merged 8 commits into from
May 20, 2024

Conversation

aciba90
Copy link
Collaborator

@aciba90 aciba90 commented May 9, 2024

Refactor black, isort, flake8 to use ruff.
Apply ruff format.

Fixes: GH-373

@aciba90 aciba90 changed the title refator: migrate to ruff refactor: migrate to ruff May 9, 2024
@a-dubs
Copy link
Contributor

a-dubs commented May 9, 2024

what is the benefit of using ruff vs black and isort?

@aciba90
Copy link
Collaborator Author

aciba90 commented May 9, 2024

what is the benefit of using ruff vs black and isort?

Generally the advantage of ruff is speed. In the case of black and isort there is not a huge difference, but having a single tool reduces complexity and dependencies.

Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! See my inline comments.

pyproject.toml Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
.pylintrc Outdated Show resolved Hide resolved
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit inline, but otherwise LGTM!

tox.ini Outdated Show resolved Hide resolved
@aciba90 aciba90 merged commit 3fb4664 into canonical:main May 20, 2024
4 checks passed
@aciba90 aciba90 deleted the docstrings branch May 20, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate away from deprecated docstring linter
3 participants