Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename kr/pretty to canonical/pretty #2

Closed
wants to merge 1 commit into from
Closed

Rename kr/pretty to canonical/pretty #2

wants to merge 1 commit into from

Conversation

barrettj12
Copy link
Collaborator

Should fix import errors encountered e.g. here

benhoyt
benhoyt approved these changes Aug 25, 2022
View reviewed changes
Copy link
Collaborator

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wouldn't do the rename though -- will make it harder to diff against or merge to upstream (assuming that happens).

@barrettj12
Copy link
Collaborator Author

barrettj12 commented Aug 25, 2022 •
edited

If that happens, we can just cherry-pick out this commit. We should fix your PR kr#87 though so that it's not based on the main branch.

@barrettj12 barrettj12 closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@barrettj12 @benhoyt