Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump node from v16 to v20 LTS #5210

Merged
merged 9 commits into from
Nov 16, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 12 additions & 10 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,16 @@ on:
pull_request:
types: [opened, synchronize, reopened]
jobs:
read-node-version:
name: "Read NodeJS version"
runs-on: ubuntu-22.04
steps:
- name: "Read .nvmrc"
run: "echo NVMRC=`cat .nvmrc` >> $GITHUB_ENV"
ndv99 marked this conversation as resolved.
Show resolved Hide resolved
lint:
name: Lint
needs: read-node-version
runs-on: ubuntu-22.04
strategy:
matrix:
node-version: [16.x]
steps:
- uses: actions/checkout@v4
- name: Restore node_modules
Expand All @@ -20,21 +24,19 @@ jobs:
with:
path: "**/node_modules"
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js ${{ env.NVMRC }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: ${{ env.NVMRC }}
- name: Install
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: CYPRESS_INSTALL_BINARY=0 yarn install
- run: yarn lint

test:
name: Test
needs: read-node-version
runs-on: ubuntu-22.04
strategy:
matrix:
node-version: [16.x]
steps:
- uses: actions/checkout@v4
- name: Restore node_modules
Expand All @@ -43,10 +45,10 @@ jobs:
with:
path: "**/node_modules"
key: ${{ runner.os }}-modules-${{ hashFiles('**/yarn.lock') }}
- name: Use Node.js ${{ matrix.node-version }}
- name: Use Node.js ${{ env.NVMRC }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
node-version: ${{ env.NVMRC }}
- name: Install
if: steps.yarn-cache.outputs.cache-hit != 'true'
run: CYPRESS_INSTALL_BINARY=0 yarn install
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v20