Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-3929] - feat: secrets integration #105

Merged
merged 55 commits into from May 3, 2024
Merged

[DPE-3929] - feat: secrets integration #105

merged 55 commits into from May 3, 2024

Conversation

marcoppenheimer
Copy link
Contributor

@marcoppenheimer marcoppenheimer commented Apr 28, 2024

NOTE: Majority of changes are synced from canonical/kafka-operator#189. See that PR for features, refactoring and bug-fixes.

K8s Specific Changes

fix: spurious error on upgrades when container wasn't ready
  • Fixed by adding a can_connect at the start of the upgrade-specific pebble-ready
chore: drop exec failure logs down to DEBUG
  • Was really noisy with the ca already exists keytool logging when re-writing the CA to the truststore

Test Changes

test: remove mTLS tests
  • These weren't working, and mTLS is generally an untested feature on K8s; it's only present as a result of VM syncing
  • Should be addressed in a dedicated ticket
test: add scaling and client-broken checks to tls tests
test: pytest.mark.unstable network_cut_without_ip_change and tls_pod_reschedule
  • I suspect it's CI flakey, not a failure of the code (they pass locally)
  • Let's let the user decide if they want to log out or not
test: re-enable some commented unit tests
test: sync unit tests with VM
  • Useful feature of adding a pytestmark = pytest.mark.skipif(SUBSTRATE="k8s") to skip an entire module's tests
test: enable upgrade int tests after stable release
  • These were disabled as we didn't have a stable release, we do now, so now we have tests
test: add consume action to app-charm for use in upgrade int tests
  • Persists credentials to peer-data so that they can be used in the consumer

@marcoppenheimer marcoppenheimer requested review from zmraul, deusebio and Batalex and removed request for zmraul and deusebio May 1, 2024 15:26
@marcoppenheimer marcoppenheimer marked this pull request as ready for review May 1, 2024 15:26
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following discussions and approval on canonical/kafka-operator#189

Copy link
Contributor

@Batalex Batalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like you said, a lot of test tweaking!

tests/integration/app-charm/src/charm.py Outdated Show resolved Hide resolved
tests/integration/app-charm/src/charm.py Show resolved Hide resolved
@marcoppenheimer marcoppenheimer merged commit dd5ab7e into main May 3, 2024
15 checks passed
@marcoppenheimer marcoppenheimer deleted the feat/secrets branch May 3, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants