Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: fix tip-flake8 and tip-mypy #1896

Merged
merged 3 commits into from Dec 7, 2022
Merged

Conversation

aciba90
Copy link
Contributor

@aciba90 aciba90 commented Dec 7, 2022

Proposed Commit Message

lint: fix tip-flake8 and tip-mypy

Improve also test doc.

Additional Context

https://jenkins.canonical.com/server-team/view/cloud-init/job/cloud-init-style-tip/239/console
PyCQA/pyflakes#684

Test Steps

tox -e tip-flake8,tip-mypy

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@aciba90 aciba90 changed the title lint: fix tip-flake8 lint: fix tip-flake8 and tip-mypy Dec 7, 2022
Copy link
Member

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheRealFalcon TheRealFalcon merged commit c273d0e into canonical:main Dec 7, 2022
@aciba90 aciba90 deleted the tip-flake8 branch December 7, 2022 14:52
@blackboxsw blackboxsw mentioned this pull request Dec 15, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants