feat: validate devel bases with craft-application #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
3 tasks
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
changed the title
lengau
reviewed
Apr 12, 2024
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Free charmcraft development! Snapcraft, rockcraft, and charmcraft all define bases differently, I would have botched the craft-application code had I not tested it everywhere. |
|
This PR will need to land after the next craft-application release. I'm leaving this open and marked as a DRAFT to prevent accidental merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For canonical/craft-application#302 and canonical/craft-application#298