feat(testing): add spread testing template files #1514
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Jinja2 template files for machine charm testing, installed when initializing a minimal charm with `charmcraft init --profile machine`. Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
commented
Feb 9, 2024
Comment on lines
51
to
53
| cmd = f"{os.environ['SNAP']}/bin/spread" | ||
| with emit.pause(): | ||
| subprocess.run([cmd, "-v", *self.arguments], check=True) |
There was a problem hiding this comment.
This is experimental code. This must be better handled before reaching production.
|
This first iteration runs spread in verbose mode. Output example: |
cmatsuoka
force-pushed
the
charm-spread-minimal
branch
from
30620c9
to
9d75ee3
Compare
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
charm-spread-minimal
branch
from
9d75ee3
to
2bf8b8d
Compare
mr-cal
approved these changes
Feb 9, 2024
lengau
requested changes
Feb 12, 2024
| users: | ||
| - default | ||
| - name: spread | ||
| plain_text_passwd: spread |
There was a problem hiding this comment.
Is there a way to do this using spread's generated passwords?
If you don't have a simple way to do it immediately, please make an issue so we don't forget about it - I don't want spread/spread to become one of the username/password pairs bad guys start scanning cloud services with :-)
| @@ -0,0 +1,32 @@ | |||
|
|
|||
There was a problem hiding this comment.
Probably worth a comment up here explaining what these functions are used for.
| CHARMCRAFT_CHANNEL/alt1,alt3: latest/stable | ||
| CHARMCRAFT_CHANNEL/alt2: latest/candidate | ||
|
|
||
| # This creates 3 test variants: |
There was a problem hiding this comment.
This might make more sense above environment?
Comment on lines
26
to
31
| install_lxd | ||
| snap install charmcraft --classic --channel "$CHARMCRAFT_CHANNEL" | ||
| snap install juju --classic --channel "$JUJU_CHANNEL" | ||
| mkdir -p "$HOME"/.local/share/juju | ||
|
|
||
| bootstrap_juju |
There was a problem hiding this comment.
Shouldn't we be doing this once per runner in spread.yaml?
| @@ -64,6 +64,9 @@ apps: | |||
| # same for config | |||
| XDG_CONFIG_HOME: $SNAP_USER_COMMON/config | |||
|
|
|||
| spread: | |||
There was a problem hiding this comment.
I'd rather not have a separate charmcraft.spread application for now.
| def run(self, parsed_args: argparse.Namespace): | ||
| """Execute command's actual functionality.""" | ||
| try: | ||
| cmd = f"{os.environ['SNAP']}/bin/spread" |
There was a problem hiding this comment.
Suggested change
| cmd = f"{os.environ['SNAP']}/bin/spread" | |
| # TODO: Make this work without Charmcraft being snapped | |
| cmd = f"{os.environ['SNAP']}/bin/spread" |
Thinking of our users on macos :-)
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
charm-spread-minimal
branch
from
a51ebd8
to
6f84191
Compare
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
charm-spread-minimal
branch
from
568ee53
to
999cb05
Compare
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
cmatsuoka
force-pushed
the
charm-spread-minimal
branch
from
7e01e99
to
9153264
Compare
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Jinja2 template files for machine charm testing, installed when
initializing a minimal charm with
charmcraft init --profile machine.Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com