Set controller channel to 3.4 in CI #40
Merged
+374
−377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functional tests requiered some changes, they were done strangely and I'm not sure why they worked before. I think it's maybe due [1], but I did not have time to investigate more. --- [1]: pytest-dev/pytest-asyncio#706
rgildein
force-pushed
the
release/BSENG-2331/support-juju-3.4
branch
from
004731c
to
62c2f9b
Compare
rgildein
force-pushed
the
release/BSENG-2331/support-juju-3.4
branch
from
27d3c88
to
c0a9105
Compare
aieri
approved these changes
Apr 11, 2024
Pjack
reviewed
Apr 12, 2024
rgildein
force-pushed
the
release/BSENG-2331/support-juju-3.4
branch
from
ff6af0e
to
a6bb7d3
Compare
Pjack
approved these changes
Apr 16, 2024
chanchiwai-ray
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functional tests required some changes, they were done in a strange way with fixtures, and I'm not sure why they worked before. I think it's maybe due 1, but I did not have time to investigate more.
Add workflow concurrency to avoid running multiple workflows on a single PR. Like this if new commit arrived the previous run will be canceled by new run.