Ensure JSON keys match in language files, and fixes bug with fairnessImplementation Strings #101
Conversation
|
This should fail still requires keys to be fixed. |
|
Also please note as mentioned earlier this is failing intentionally right now to let us know what keys need to be fixed. I'll continue to rebase this until it's been fixed. |
|
👍 Not merging until you give me the ✔️ |
|
for #96. Well it'll be waiting on all the french text to be added before I can merge it, |
|
What French terms are missing? |
|
Sorry just saw this now they get spit out during the test: Will probably have to rebase and run again. |
CalvinRodo
force-pushed
the
i18n-key-test
branch
from
fd125e0
to
bf28ffa
Compare
|
OK, Will shortly look at it. Working on Thursday's workshop
Le mar. 18 juin 2019 09 h 04, Calvin Rodo <notifications@github.com> a
écrit :
… Sorry just saw this now they get spit out during the test:
extra keys in en.json
proceduralFairnessImplementation1
proceduralFairnessImplementation2
proceduralFairnessImplementation3
proceduralFairnessImplementation4
proceduralFairnessImplementation5
proceduralFairnessImplementation6
proceduralFairnessImplementation7
proceduralFairnessImplementation8
proceduralFairnessImplementation9
proceduralFairnessImplementation10
proceduralFairnessImplementation11
proceduralFairnessImplementation12
proceduralFairnessImplementation13
proceduralFairnessImplementation14
proceduralFairnessImplementation15
proceduralFairnessImplementation16
proceduralFairnessImplementation17 extra keys in fr.json
Will probably have to rebase and run again.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#101?email_source=notifications&email_token=AAM4TZK5AFUEAE62ZRNYIJTP3DMORA5CNFSM4HPV2VP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX6RRLA#issuecomment-503126188>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAM4TZPCYZNEUNM43XUI3L3P3DMORANCNFSM4HPV2VPQ>
.
|
CalvinRodo
force-pushed
the
i18n-key-test
branch
from
bf28ffa
to
a932cc8
Compare
|
@gcharest Any update on this do we need to add these questions in French or can we remove them from the English? |
|
Yes, I'll review shortly. Was scheduled this morning but got sidetracked. |
CalvinRodo
force-pushed
the
i18n-key-test
branch
from
a932cc8
to
d2bbf6a
Compare
|
Just a reminder to @gcharest or @MrDeshaies to validate the missing keys this test will be really useful for anyone adding new languages to the project since they'll be able to validate that the keys are matching. |
|
Found the reason for the failure it was because of a bug in the coding of the fairnessImplementation strings This PR fixes Bug #130 |
CalvinRodo
changed the title
Added lodash Added a test that fails if the number of keys in one language file doesn't match the number in the other. Will spit out the extra keys if it fails.
CalvinRodo
force-pushed
the
i18n-key-test
branch
from
482f71a
to
ff7ad89
Compare
| @@ -55,6 +55,7 @@ | |||
| "eslint-plugin-vue": "^5.0.0", | |||
| "jest-transform-stub": "^2.0.0", | |||
| "push-dir": "^0.4.1", | |||
| "lodash": "^4.17.11", | |||
There was a problem hiding this comment.
I forget how this package changed its deployment, but I think it might be better to install the individual components of lodash you're using instead of the full library. EX: lodash.isempty above in the dependencies
|
My view was because it's just a dev dependency it wasn't worth tracking
down how i used it. but I can do that if you want.
…On Thu, Oct 10, 2019 at 12:47 PM Nick Schonning ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In package.json
<#101 (comment)>:
> @@ -55,6 +55,7 @@
"eslint-plugin-vue": "^5.0.0",
"jest-transform-stub": "^2.0.0",
"push-dir": "^0.4.1",
+ "lodash": "^4.17.11",
I forget how this package changed its deployment, but I think it might be
better to install the individual components of lodash you're using instead
of the full library. EX: lodash.isempty above in the dependencies
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#101?email_source=notifications&email_token=AAAVNOSRLV3TYWMZNMBTD5DQN5MDPA5CNFSM4HPV2VP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHSNCCI#pullrequestreview-300208393>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAVNOW47A43XBZTOPNLCWLQN5MDPANCNFSM4HPV2VPQ>
.
--
-Calvin Rodo
|
|
Looks like https://www.npmjs.com/package/lodash.intersection and https://www.npmjs.com/package/lodash.difference |
No description provided.