Create EventAppliers in engine #9985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 4, 2022
9985: Create EventAppliers in engine r=Zelldon a=Zelldon ## Description The StreamProcessor nor the builder doesn't need the knowledge about the EventAppliers. Currently there is no need to set this from outside. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Timed out. |
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 4, 2022
9985: Create EventAppliers in engine r=Zelldon a=Zelldon ## Description The StreamProcessor nor the builder doesn't need the knowledge about the EventAppliers. Currently there is no need to set this from outside. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Timed out. |
|
There some tests failing because the need to set the event applies as mocks, we can resolve this with #9989 since we can set the RecordProcessor from outside (as spy for example) to verify things we do in the tests. |
Zelldon
force-pushed
the
zell-clean-up-abstractions
branch
from
73850d2
to
8ed2736
Compare
The StreamProcessor nor the builder doesn't need the knowledge about the EventAppliers. Currently there is no need to set this from outside.
Zelldon
force-pushed
the
zell-clean-up-abstractions
branch
from
8ed2736
to
79bf2bc
Compare
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 8, 2022
9985: Create EventAppliers in engine r=Zelldon a=Zelldon ## Description The StreamProcessor nor the builder doesn't need the knowledge about the EventAppliers. Currently there is no need to set this from outside. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Timed out. |
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 8, 2022
9985: Create EventAppliers in engine r=Zelldon a=Zelldon ## Description The StreamProcessor nor the builder doesn't need the knowledge about the EventAppliers. Currently there is no need to set this from outside. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed: |
|
bors r+ |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 8, 2022
9985: Create EventAppliers in engine r=Zelldon a=Zelldon ## Description The StreamProcessor nor the builder doesn't need the knowledge about the EventAppliers. Currently there is no need to set this from outside. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
|
Build failed: |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 8, 2022
9753: Document events and event scopes r=korthout a=korthout ## Description <!-- Please explain the changes you made here. --> This provides an initial description of events and event scopes. It uses both the BPMN specification as well as the terminology used in Zeebe to describe events, triggers, and event scopes. ## Related issues <!-- Which issues are closed by this PR or are related --> NA 10021: Engine abstraction code cleanup r=pihme a=pihme ## Description * Removes unnecessary references * Moves `LegacyTypedResponseWriter` to stream processor, as it is only used in this package * Renames `LegacyTypedResponseWriter` ## Related issues related to #9727 10028: Revert "Merge pull request #9985 from camunda/zell-clean-up-abstracti… r=Zelldon a=Zelldon ## Description This reverts commit 155de10, reversing changes made to 47c3d3a. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> related to #10027 Co-authored-by: Nico Korthout <nico.korthout@camunda.com> Co-authored-by: pihme <pihme@users.noreply.github.com> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Zelldon
added a commit
that referenced
this pull request
Aug 9, 2022
…bstractions"" This reverts commit 7a8db74.
10 tasks
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 15, 2022
10036: Create new StreamPlatformExtension r=Zelldon a=Zelldon ## Description This is an attempt to create a new StreamPlatformExtension, which should allow us to replace the TestStreams, StreamProcessorComposite, and StreamProcessorRule. This is something that would help us to continue with cleaning up the engine/stream processing code (and tests). There was a recent attempt to remove the event applies from the stream processing interface, #9985 but this failed since several tests have high dependencies on how the engine and related stuff is built. They are highly coupled. This is just a first step and I would like to validate with you `@saig0` and `@npepinpe,` since I think you both are quite familiar with JUnit 5 extensions and our old rules. (Note: I'm a total junit 5 noob please bare with me.) _What the PR does:_ - Introduce a new class StreamPlatform (combination of [TestStreams](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/util/TestStreams.java) and [StreamComposite](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/util/StreamProcessingComposite.java)) - Introduce a new extension to create the StreamPlatform and make this available for tests - Created an example test which is a copy of [StreamProcessorReplayModeTest.java](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/processing/streamprocessor/StreamProcessorReplayModeTest.java) In the test class we can see how it would look like and what the stream platform could provide us. Instead of always registering mocked typed processors in streamProcessors tests we just have on mocked RecordProcessor which can be use for verifications. I think this would simplify our tests a lot, since it is currently a lot of boilter plate which is mostly for the tests not interesting at all. Be aware that it currently only contains one test to show how it could look like and get early feedback. Please take a look and let me know what you think. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes # Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 15, 2022
10036: Create new StreamPlatformExtension r=Zelldon a=Zelldon ## Description This is an attempt to create a new StreamPlatformExtension, which should allow us to replace the TestStreams, StreamProcessorComposite, and StreamProcessorRule. This is something that would help us to continue with cleaning up the engine/stream processing code (and tests). There was a recent attempt to remove the event applies from the stream processing interface, #9985 but this failed since several tests have high dependencies on how the engine and related stuff is built. They are highly coupled. This is just a first step and I would like to validate with you `@saig0` and `@npepinpe,` since I think you both are quite familiar with JUnit 5 extensions and our old rules. (Note: I'm a total junit 5 noob please bare with me.) _What the PR does:_ - Introduce a new class StreamPlatform (combination of [TestStreams](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/util/TestStreams.java) and [StreamComposite](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/util/StreamProcessingComposite.java)) - Introduce a new extension to create the StreamPlatform and make this available for tests - Created an example test which is a copy of [StreamProcessorReplayModeTest.java](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/processing/streamprocessor/StreamProcessorReplayModeTest.java) In the test class we can see how it would look like and what the stream platform could provide us. Instead of always registering mocked typed processors in streamProcessors tests we just have on mocked RecordProcessor which can be use for verifications. I think this would simplify our tests a lot, since it is currently a lot of boilter plate which is mostly for the tests not interesting at all. Be aware that it currently only contains one test to show how it could look like and get early feedback. Please take a look and let me know what you think. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes # Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Aug 15, 2022
10036: Create new StreamPlatformExtension r=Zelldon a=Zelldon ## Description This is an attempt to create a new StreamPlatformExtension, which should allow us to replace the TestStreams, StreamProcessorComposite, and StreamProcessorRule. This is something that would help us to continue with cleaning up the engine/stream processing code (and tests). There was a recent attempt to remove the event applies from the stream processing interface, #9985 but this failed since several tests have high dependencies on how the engine and related stuff is built. They are highly coupled. This is just a first step and I would like to validate with you `@saig0` and `@npepinpe,` since I think you both are quite familiar with JUnit 5 extensions and our old rules. (Note: I'm a total junit 5 noob please bare with me.) _What the PR does:_ - Introduce a new class StreamPlatform (combination of [TestStreams](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/util/TestStreams.java) and [StreamComposite](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/util/StreamProcessingComposite.java)) - Introduce a new extension to create the StreamPlatform and make this available for tests - Created an example test which is a copy of [StreamProcessorReplayModeTest.java](https://github.com/camunda/zeebe/blob/main/engine/src/test/java/io/camunda/zeebe/engine/processing/streamprocessor/StreamProcessorReplayModeTest.java) In the test class we can see how it would look like and what the stream platform could provide us. Instead of always registering mocked typed processors in streamProcessors tests we just have on mocked RecordProcessor which can be use for verifications. I think this would simplify our tests a lot, since it is currently a lot of boilter plate which is mostly for the tests not interesting at all. Be aware that it currently only contains one test to show how it could look like and get early feedback. Please take a look and let me know what you think. <!-- Please explain the changes you made here. --> ## Related issues <!-- Which issues are closed by this PR or are related --> closes # Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
18 tasks
Zelldon
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The StreamProcessor nor the builder doesn't need the knowledge about the EventAppliers. Currently there is no need to set this from outside.
Related issues
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.