Improve s3 backup store client reliability #10603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleschoenburg
force-pushed
the
10547-s3-backup-store-reliability
branch
from
45789b1
to
0284d98
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -19,6 +20,8 @@ | |||
| * try to discover an appropriate value from the environment. | |||
| * @param credentials If no value is provided, the AWS SDK will try to discover appropriate values | |||
| * from the environment. | |||
| * @param apiCallTimeout Used as the overall api call timeout for the AWS SDK. API calls that exceed | |||
Check notice
Code scanning / CodeQL
Spurious Javadoc @param tags
oleschoenburg
force-pushed
the
10547-s3-backup-store-reliability
branch
from
0284d98
to
f7bc1cf
Compare
deepthidevaki
requested changes
Oct 5, 2022
| @@ -17,6 +18,7 @@ public class S3BackupStoreConfig implements ConfigurationEntry { | |||
| private String region; | |||
| private String accessKey; | |||
| private String secretKey; | |||
| private Duration apiCallTimeout; | |||
There was a problem hiding this comment.
🔧 I suggest to provide a default value.
There was a problem hiding this comment.
I've set it to 180 seconds. If we assume that the largest file of a backup is a 128MiB segment this requires less than 1MiB/s throughput which should be reasonable.
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Oct 6, 2022
10593: deps(maven): bump proto-google-common-protos from 2.9.3 to 2.9.6 r=oleschoenburg a=dependabot[bot] Bumps [proto-google-common-protos](https://github.com/googleapis/java-iam) from 2.9.3 to 2.9.6. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/googleapis/java-iam/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting ``@dependabot` rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - ``@dependabot` rebase` will rebase this PR - ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it - ``@dependabot` merge` will merge this PR after your CI passes on it - ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it - ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging - ``@dependabot` reopen` will reopen this PR if it is closed - ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> 10603: Improve s3 backup store client reliability r=oleschoenburg a=oleschoenburg This adds the ability to set an overall api call timeout which appears to be the only thing that fixes #10547. Additionally, some other configuration for the client is updated to smooth out load spikes when taking backups and to automatically adjust various other parameters based on the detected environment. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed (retrying...): |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Oct 6, 2022
10603: Improve s3 backup store client reliability r=oleschoenburg a=oleschoenburg This adds the ability to set an overall api call timeout which appears to be the only thing that fixes #10547. Additionally, some other configuration for the client is updated to smooth out load spikes when taking backups and to automatically adjust various other parameters based on the detected environment. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors retry |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Oct 6, 2022
10603: Improve s3 backup store client reliability r=oleschoenburg a=oleschoenburg This adds the ability to set an overall api call timeout which appears to be the only thing that fixes #10547. Additionally, some other configuration for the client is updated to smooth out load spikes when taking backups and to automatically adjust various other parameters based on the detected environment. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors retry |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Oct 6, 2022
10603: Improve s3 backup store client reliability r=oleschoenburg a=oleschoenburg This adds the ability to set an overall api call timeout which appears to be the only thing that fixes #10547. Additionally, some other configuration for the client is updated to smooth out load spikes when taking backups and to automatically adjust various other parameters based on the detected environment. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors retry |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Oct 6, 2022
10603: Improve s3 backup store client reliability r=oleschoenburg a=oleschoenburg This adds the ability to set an overall api call timeout which appears to be the only thing that fixes #10547. Additionally, some other configuration for the client is updated to smooth out load spikes when taking backups and to automatically adjust various other parameters based on the detected environment. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
|
Successfully created backport PR #10619 for |
korthout
added
the
version:8.1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to set an overall api call timeout which appears to be the only thing that fixes #10547. Additionally, some other configuration for the client is updated to smooth out load spikes when taking backups and to automatically adjust various other parameters based on the detected environment.