Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove proxy writers #10000

Merged
merged 2 commits into from Aug 8, 2022
Merged

Remove proxy writers #10000

merged 2 commits into from Aug 8, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Aug 4, 2022

Description

After #9967 is merged we can look at this PR.

Removes the proxy writers, which have been introduced for not writing on reprocessing, which we no longer do.

Related issues

related to #9727

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022 •
edited

Test Results

   810 files  ±  0     810 suites  ±0   1h 37m 47s ⏱️ + 3m 17s
6 063 tests +16  6 052 ✔️ +16  11 💤 ±0  0 ❌ ±0 
6 251 runs  +16  6 240 ✔️ +16  11 💤 ±0  0 ❌ ±0 

Results for commit dafd76c. ± Comparison against base commit c017448.

♻️ This comment has been updated with latest results.

@Zelldon Zelldon requested a review from saig0 August 4, 2022 19:40
@Zelldon Zelldon marked this pull request as ready for review August 4, 2022 19:40
saig0
saig0 approved these changes Aug 5, 2022
View reviewed changes
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zelldon LTGM 🗑️

Please rebase with #9994 before.

@Zelldon Zelldon mentioned this pull request Aug 5, 2022
Merged
10 tasks
@Zelldon Zelldon force-pushed the zell-writers-further-clean-up branch from 07f3fc9 to c8dd038 Compare August 5, 2022 12:13
@Zelldon
Copy link
Member Author

Zelldon commented Aug 5, 2022

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 5, 2022
@zeebe-bors-camunda @Zelldon
merge: #10000
f9b921e 
10000: Remove proxy writers r=Zelldon a=Zelldon

## Description

After #9967 is merged we can look at this PR.
<!-- Please explain the changes you made here. -->
Removes the proxy writers, which have been introduced for not writing on reprocessing, which we no longer do.


## Related issues

<!-- Which issues are closed by this PR or are related -->

related to #9727



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@Zelldon
refactor: clean up ProcessingScheduleService
085436f 
Remove the LegacyTask and the related writer in the schedule service, since it was not used. We will implement it differently.
@Zelldon
refactor: remove stream writer proxy
dafd76c 
The proxy was introduced to disable writing during reprocressing, we no longer do reprocessing so this is no longer necessary an can be removed.
@Zelldon Zelldon force-pushed the zell-writers-further-clean-up branch from c8dd038 to dafd76c Compare August 8, 2022 07:18
@Zelldon
Copy link
Member Author

Zelldon commented Aug 8, 2022

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 8, 2022
@zeebe-bors-camunda @Zelldon
merge: #10000
e434282 
10000: Remove proxy writers r=Zelldon a=Zelldon

## Description

After #9967 is merged we can look at this PR.
<!-- Please explain the changes you made here. -->
Removes the proxy writers, which have been introduced for not writing on reprocessing, which we no longer do.


## Related issues

<!-- Which issues are closed by this PR or are related -->

related to #9727



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@Zelldon
Copy link
Member Author

Zelldon commented Aug 8, 2022

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 8, 2022
@zeebe-bors-camunda @Zelldon
merge: #10000
4553951 
10000: Remove proxy writers r=Zelldon a=Zelldon

## Description

After #9967 is merged we can look at this PR.
<!-- Please explain the changes you made here. -->
Removes the proxy writers, which have been introduced for not writing on reprocessing, which we no longer do.


## Related issues

<!-- Which issues are closed by this PR or are related -->

related to #9727



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@Zelldon
Copy link
Member Author

Zelldon commented Aug 8, 2022

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 8, 2022
@zeebe-bors-camunda @Zelldon
merge: #10000
20ea077 
10000: Remove proxy writers r=Zelldon a=Zelldon

## Description

After #9967 is merged we can look at this PR.
<!-- Please explain the changes you made here. -->
Removes the proxy writers, which have been introduced for not writing on reprocessing, which we no longer do.


## Related issues

<!-- Which issues are closed by this PR or are related -->

related to #9727



Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
@Zelldon Zelldon merged commit e090e11 into main Aug 8, 2022
@Zelldon Zelldon deleted the zell-writers-further-clean-up branch August 8, 2022 09:38
@Zelldon
Copy link
Member Author

Zelldon commented Aug 8, 2022

bors r-

@zeebe-bors-camunda
Copy link
Contributor

Canceled.

@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saig0 saig0 saig0 approved these changes

Assignees
No one assigned
Labels
version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zelldon @saig0 @deepthidevaki