Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RandomizedRaftTest test results can't be parsed by publish-unit-test-result-action #9959

Closed
oleschoenburg opened this issue Aug 3, 2022 · 0 comments
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@oleschoenburg
Copy link
Member

oleschoenburg commented Aug 3, 2022

Description

The action regularly fails for the test report of RandomizedRaftTest, as seen here: https://github.com/camunda/zeebe/runs/7635283044?check_suite_focus=true#step:4:37

Error: lxml.etree.XMLSyntaxError: CData section too big found, line 112608, column 144
Error: Error processing result file: CData section too big found, line 112608, column 144 (TEST-io.atomix.raft.RandomizedRaftTest.xml, line 112608)

It seems like the action uses libxml which can't deal with such a large (~60MB) XML file: https://gitlab.gnome.org/GNOME/libxml2/-/blob/master/parser.c#L9802

The test report XML is too large because it includes the logs that were written during the test, even though we tell surefire to redirectTestOutputToFile:

<redirectTestOutputToFile>true</redirectTestOutputToFile>

This was introduced by https://issues.apache.org/jira/browse/SUREFIRE-1744, and is tracked as a bug here: https://issues.apache.org/jira/browse/SUREFIRE-1934

@oleschoenburg oleschoenburg added kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) labels Aug 3, 2022
zeebe-bors-camunda bot added a commit that referenced this issue Aug 3, 2022
9965: chore(ci): remove system-out from test output xml r=menski a=menski

## Description

Mitigate to large test output files by deleting the system-out element using sed.

Note: we cannot use XML tools like xmlstarlet as they all suffer the same libxml2 limitation

Also replaces the deprecated usage of `files` with `junit_files` in the publish test result action.
 
## Related issues

related #9959



Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
zeebe-bors-camunda bot added a commit that referenced this issue Aug 3, 2022
9965: chore(ci): remove system-out from test output xml r=menski a=menski

## Description

Mitigate to large test output files by deleting the system-out element using sed.

Note: we cannot use XML tools like xmlstarlet as they all suffer the same libxml2 limitation

Also replaces the deprecated usage of `files` with `junit_files` in the publish test result action.
 
## Related issues

related #9959



Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Marks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.) kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

No branches or pull requests

3 participants