Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove system-out from test output xml #9965

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

menski
Copy link
Contributor

@menski menski commented Aug 3, 2022

Description

Mitigate to large test output files by deleting the system-out element using sed.

Note: we cannot use XML tools like xmlstarlet as they all suffer the same libxml2 limitation

Also replaces the deprecated usage of files with junit_files in the publish test result action.

Related issues

related #9959

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2022

Test Results

   804 files  ±    0         1 errors  803 suites  ±0   1h 36m 35s ⏱️ + 4m 16s
6 336 tests +374  6 327 ✔️ +374  9 💤 ±0  0 ±0 
6 522 runs  +374  6 513 ✔️ +374  9 💤 ±0  0 ±0 

For more details on these parsing errors, see this check.

Results for commit 4b45d6f. ± Comparison against base commit 77114d6.

♻️ This comment has been updated with latest results.

Mitigate to large test output files by deleting the system-out element
using sed.

Note: we cannot use XML tools like xmlstarlet as they all suffer the
same libxml2 limitation
The deprecation was introduced with version 2.0 of the publish unit test
result action
https://github.com/EnricoMi/publish-unit-test-result-action/releases/tag/v2.0.0-alpha
@menski menski force-pushed the 9959-mitigate-large-system-out branch from fe11913 to 4b45d6f Compare August 3, 2022 13:31
@menski menski marked this pull request as ready for review August 3, 2022 13:35
@menski
Copy link
Contributor Author

menski commented Aug 3, 2022

Please note that the "Publish Test Result" workflow is always picked up from main branch, so this changes will only take effect after the merge. You can find an example run in my personal fork https://github.com/menski/zeebe/actions/runs/2789777745

@lenaschoenburg
Copy link
Member

@menski Could you do one more test to verify that failing tests are still handled correctly and that the output we see from the is okay? I think it'd be as easy as breaking one of our tests intentionally and seeing what is being reported.

@menski
Copy link
Contributor Author

menski commented Aug 3, 2022

sure let me break stuff

@menski
Copy link
Contributor Author

menski commented Aug 3, 2022

Running test: https://github.com/menski/zeebe/pull/80

@menski
Copy link
Contributor Author

menski commented Aug 3, 2022

@oleschoenburg results of the test are posted here, as I'm not familiar with the expect output/format, can you check if it is what you expected?

Copy link
Member

@lenaschoenburg lenaschoenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, report still looks good and includes the stacktrace of the failing assertion 👍

@menski
Copy link
Contributor Author

menski commented Aug 3, 2022

bors r+

zeebe-bors-camunda bot added a commit that referenced this pull request Aug 3, 2022
9965: chore(ci): remove system-out from test output xml r=menski a=menski

## Description

Mitigate to large test output files by deleting the system-out element using sed.

Note: we cannot use XML tools like xmlstarlet as they all suffer the same libxml2 limitation

Also replaces the deprecated usage of `files` with `junit_files` in the publish test result action.
 
## Related issues

related #9959



Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@menski
Copy link
Contributor Author

menski commented Aug 3, 2022

bors retry

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 0e6c55d into main Aug 3, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the 9959-mitigate-large-system-out branch August 3, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants