-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): remove system-out from test output xml #9965
Conversation
Test Results 804 files ± 0 1 errors 803 suites ±0 1h 36m 35s ⏱️ + 4m 16s For more details on these parsing errors, see this check. Results for commit 4b45d6f. ± Comparison against base commit 77114d6. ♻️ This comment has been updated with latest results. |
Mitigate to large test output files by deleting the system-out element using sed. Note: we cannot use XML tools like xmlstarlet as they all suffer the same libxml2 limitation
The deprecation was introduced with version 2.0 of the publish unit test result action https://github.com/EnricoMi/publish-unit-test-result-action/releases/tag/v2.0.0-alpha
fe11913
to
4b45d6f
Compare
Please note that the "Publish Test Result" workflow is always picked up from |
@menski Could you do one more test to verify that failing tests are still handled correctly and that the output we see from the is okay? I think it'd be as easy as breaking one of our tests intentionally and seeing what is being reported. |
sure let me break stuff |
Running test: https://github.com/menski/zeebe/pull/80 |
@oleschoenburg results of the test are posted here, as I'm not familiar with the expect output/format, can you check if it is what you expected? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, report still looks good and includes the stacktrace of the failing assertion 👍
bors r+ |
9965: chore(ci): remove system-out from test output xml r=menski a=menski ## Description Mitigate to large test output files by deleting the system-out element using sed. Note: we cannot use XML tools like xmlstarlet as they all suffer the same libxml2 limitation Also replaces the deprecated usage of `files` with `junit_files` in the publish test result action. ## Related issues related #9959 Co-authored-by: Sebastian Menski <sebastian.menski@camunda.com>
Build failed: |
bors retry |
Build succeeded: |
Description
Mitigate to large test output files by deleting the system-out element using sed.
Note: we cannot use XML tools like xmlstarlet as they all suffer the same libxml2 limitation
Also replaces the deprecated usage of
files
withjunit_files
in the publish test result action.Related issues
related #9959
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.