Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport stable/8.0] Support deploying multiple DMN files at once #9458

Merged
merged 3 commits into from May 30, 2022

Conversation

backport-action
Copy link
Collaborator

Description

Backport of #9432 to stable/8.0.

relates to camunda/zeebe-process-test#357 #9337 #9115

remcowesterhoud and others added 3 commits May 30, 2022 05:27
Our testcases were missing a scenario where we deploy multiple DRGs at once.

(cherry picked from commit 4a912e0)
When writing the records after deploying a new DRG we would iterate over all the drgs and decisions in the DeploymentRecord. New drgs and decisions get gradually appended to the DeploymentRecord for each resource that's being processed. Since we iterate over this for every resource, it causes the same event to be send multiple times. Once for each of the drgs deployed.

By filtering the drg metadata that is available in the DeploymentRecord to only include the resource that we are currently transforming we can stop this behavior and support deploying multiple drgs at once.

(cherry picked from commit 223d5c7)
* make it clear that there is at most one decision requirements event that should be written

(cherry picked from commit 011da00)
@remcowesterhoud
Copy link
Contributor

bors merge

@zeebe-bors-camunda
Copy link
Contributor

👎 Rejected by too few approved reviews

Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request May 30, 2022
9458: [Backport stable/8.0] Support deploying multiple DMN files at once r=remcowesterhoud a=backport-action

# Description
Backport of #9432 to `stable/8.0`.

relates to camunda/zeebe-process-test#357 #9337 #9115

Co-authored-by: Remco Westerhoud <remco@westerhoud.nl>
Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
@zeebe-bors-camunda
Copy link
Contributor

Build failed:

@saig0
Copy link
Member

saig0 commented May 30, 2022

bors merge

@zeebe-bors-camunda
Copy link
Contributor

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit b1cf5c2 into stable/8.0 May 30, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the backport-9432-to-stable/8.0 branch May 30, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants