Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport stable/8.0] Support deploying multiple DMN files at once #9458

Merged
merged 3 commits into from
May 30, 2022
Merged

[Backport stable/8.0] Support deploying multiple DMN files at once #9458

merged 3 commits into from
May 30, 2022

Commits on May 30, 2022

  1. test: add multiple dmn deployment test 

    Our testcases were missing a scenario where we deploy multiple DRGs at once.

(cherry picked from commit 4a912e0)
    @remcowesterhoud @github-actions
    remcowesterhoud authored and github-actions[bot] committed May 30, 2022
    Configuration menu
    Copy the full SHA
    fbe4d57 View commit details
    Browse the repository at this point in the history

  2. fix: prevent duplicate events for drgs and decisions 

    When writing the records after deploying a new DRG we would iterate over all the drgs and decisions in the DeploymentRecord. New drgs and decisions get gradually appended to the DeploymentRecord for each resource that's being processed. Since we iterate over this for every resource, it causes the same event to be send multiple times. Once for each of the drgs deployed.

By filtering the drg metadata that is available in the DeploymentRecord to only include the resource that we are currently transforming we can stop this behavior and support deploying multiple drgs at once.

(cherry picked from commit 223d5c7)
    @remcowesterhoud @github-actions
    remcowesterhoud authored and github-actions[bot] committed May 30, 2022
    Configuration menu
    Copy the full SHA
    9c5e430 View commit details
    Browse the repository at this point in the history

  3. refactor(engine): minor improvement 

    * make it clear that there is at most one decision requirements event that should be written

(cherry picked from commit 011da00)
    @saig0 @github-actions
    saig0 authored and github-actions[bot] committed May 30, 2022
    Configuration menu
    Copy the full SHA
    f12e1d0 View commit details
    Browse the repository at this point in the history