Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding deploy workflow / cancel process instance to whitelisted commands (which will be accepted when backpressure is high) #9283

Closed
pihme opened this issue May 4, 2022 · 1 comment · Fixed by #10388
Assignees
Labels
area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) kind/feature Categorizes an issue or PR as a feature, i.e. new behavior severity/mid Marks a bug as having a noticeable impact but with a known workaround version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Milestone

Comments

@pihme
Copy link
Contributor

pihme commented May 4, 2022

Is your feature request related to a problem? Please describe.
This came up during an investigation for #8991 and then follow up discussions in #9276

Currently, we allow to complete / fail jobs under backpressure.

However, some processes like fork bombs can bring the cluster into a non-productive state. Remedies in this situation include:

  • ability to cancel a process instance
  • ability to deploy a newer version of a faulty workflow

Describe the solution you'd like
Whitelist these two commands as well

@pihme pihme added kind/feature Categorizes an issue or PR as a feature, i.e. new behavior team/distributed labels May 4, 2022
@saig0 saig0 added this to the 8.1 milestone May 9, 2022
@saig0 saig0 added severity/mid Marks a bug as having a noticeable impact but with a known workaround area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) and removed team/distributed labels May 9, 2022
@saig0
Copy link
Member

saig0 commented May 9, 2022

We agree with the suggestion. The goal is to implement the change for the next minor version.

@remcowesterhoud remcowesterhoud self-assigned this Sep 16, 2022
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reliability Marks an issue as related to improving the reliability of our software (i.e. it behaves as expected) kind/feature Categorizes an issue or PR as a feature, i.e. new behavior severity/mid Marks a bug as having a noticeable impact but with a known workaround version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants