Accept Process Instance cancelling and new deployment when backpressure is high #10388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the cancelling of a process and deploying new versions of a process when backpressure is high. There are situations where a faulty process is the cause of the high backpressure. When this happens a way to resolve the issue would be to cancel the process instance. This is not possible when the cancel command gets rejected because of the backpressure. In a similar manner it could occur that a process is faulty and causing a fork-bomb with call activities, resulting in high backpressure. Redeploying a new version of the process could resolve this situation.
This assertThat never actually verified anything. The loop should remain as this is what increases the in flight requests to the limit.
This test verifies that the following action can be still done even when the backpressure is high: 1. Complete and Fail jobs 2. Cancel process instances 3. Perform new deployments
remcowesterhoud
force-pushed
the
9283_whitelist_deploy_and_cancel_command
branch
from
409d5ec
to
5b68e05
Compare
|
bors merge |
|
Build succeeded: |
zeebe-bors-camunda
bot
deleted the
9283_whitelist_deploy_and_cancel_command
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow cancelling of process instances and deployments of new processes when the back pressure is high.
It could occur that a cluster has a high back pressure because of a faulty process. This could be resolved by cancelling the instance, or by creating a new deployment. When these commands get rejected because of this high backpressure it becomes unrecoverable.
Related issues
closes #9283
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.