Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install backup manager with configured backup store #10207

Closed
Tracked by #9606
deepthidevaki opened this issue Aug 29, 2022 · 0 comments · Fixed by #10251
Closed
Tracked by #9606

Install backup manager with configured backup store #10207

deepthidevaki opened this issue Aug 29, 2022 · 0 comments · Fixed by #10251
Assignees
@deepthidevaki
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@deepthidevaki
Copy link
Contributor

Currently backup manager is configured with a noop backup store. Instead provide a configured S3BackupStore
@deepthidevaki deepthidevaki added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Aug 29, 2022
@deepthidevaki deepthidevaki mentioned this issue Aug 29, 2022
Closed
58 tasks
@deepthidevaki deepthidevaki self-assigned this Sep 1, 2022
@deepthidevaki deepthidevaki mentioned this issue Sep 1, 2022
Merged
10 tasks
zeebe-bors-camunda bot added a commit that referenced this issue Sep 2, 2022
@zeebe-bors-camunda @deepthidevaki
merge: #10251
7309135 
10251: Provide installed BackupStore when installing BackupService r=deepthidevaki a=deepthidevaki

## Description

- If a BackupStore is available, BackupManager is installed with the given BackupStore. If no backup store is available, or if it is in follower role, then a NoopBackupManager is installed.
- Re-install BackupManager only when transitioning between Leader and Follower roles. When transition between Candidate and Follower, we don't have to re-install services. This is an optimization to remove unnecessary re-installations. Other services like StreamProcessor follows the same pattern.
- Refactored the tests for the transition steps to reuse a common argument provider.

Note:- This PR assumes a backup store is installed in a different step, which is not done yet. So currently it always install a NoopBackupManager.

## Related issues

closes #10207 



Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepthidevaki deepthidevaki

Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Provide installed BackupStore when installing BackupService camunda/zeebe
2 participants
@deepthidevaki @Zelldon