Provide installed BackupStore when installing BackupService #10251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…llower roles and when no backup store is configured
When transitioning from follower to candidate and or candidate to follower, we don't have to re-install backup service.
lenaschoenburg
requested changes
Sep 1, 2022
...n/java/io/camunda/zeebe/broker/system/partitions/impl/steps/BackupServiceTransitionStep.java
Outdated
Show resolved
Hide resolved
...unda/zeebe/broker/system/partitions/impl/steps/PartitionTransitionTestArgumentProviders.java
Outdated
Show resolved
Hide resolved
...unda/zeebe/broker/system/partitions/impl/steps/PartitionTransitionTestArgumentProviders.java
Show resolved
Hide resolved
...n/java/io/camunda/zeebe/broker/system/partitions/impl/steps/BackupServiceTransitionStep.java
Outdated
Show resolved
Hide resolved
...va/io/camunda/zeebe/broker/system/partitions/impl/steps/BackupServiceTransitionStepTest.java
Show resolved
Hide resolved
...va/io/camunda/zeebe/broker/system/partitions/impl/steps/BackupServiceTransitionStepTest.java
Show resolved
Hide resolved
...unda/zeebe/broker/system/partitions/impl/steps/PartitionTransitionTestArgumentProviders.java
Outdated
Show resolved
Hide resolved
...va/io/camunda/zeebe/broker/system/partitions/impl/steps/BackupServiceTransitionStepTest.java
Outdated
Show resolved
Hide resolved
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Sep 2, 2022
10251: Provide installed BackupStore when installing BackupService r=deepthidevaki a=deepthidevaki ## Description - If a BackupStore is available, BackupManager is installed with the given BackupStore. If no backup store is available, or if it is in follower role, then a NoopBackupManager is installed. - Re-install BackupManager only when transitioning between Leader and Follower roles. When transition between Candidate and Follower, we don't have to re-install services. This is an optimization to remove unnecessary re-installations. Other services like StreamProcessor follows the same pattern. - Refactored the tests for the transition steps to reuse a common argument provider. Note:- This PR assumes a backup store is installed in a different step, which is not done yet. So currently it always install a NoopBackupManager. ## Related issues closes #10207 Co-authored-by: Deepthi Devaki Akkoorath <deepthidevaki@gmail.com>
|
Build failed: |
|
bors retry |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note:- This PR assumes a backup store is installed in a different step, which is not done yet. So currently it always install a NoopBackupManager.
Related issues
closes #10207
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.