Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace direct reset with buffered writers #10047

Closed
korthout opened this issue Aug 9, 2022 · 2 comments · Fixed by #10204
Closed

Replace direct reset with buffered writers #10047

korthout opened this issue Aug 9, 2022 · 2 comments · Fixed by #10204
Assignees
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0

Comments

@korthout
Copy link
Member

korthout commented Aug 9, 2022

Description

This is a follow-up of #10018.

Chris wants to remove the reset method altogether. And once we have the new implementation, which is based on buffered writers, the reset will no longer be necessary, as creating a new ProcessingResultBuilder will also create a new, empty buffer

See #10018 (comment)

@korthout korthout added the kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. label Aug 9, 2022
@menski
Copy link
Contributor

menski commented Aug 19, 2022

@Zelldon is that something you would pick up while you are working on the buffered writers?

@Zelldon
Copy link
Member

Zelldon commented Aug 19, 2022

Yes @menski

@Zelldon Zelldon self-assigned this Aug 19, 2022
@Zelldon Zelldon mentioned this issue Aug 26, 2022
10 tasks
@Zelldon Zelldon added the version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/toil Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc. version:8.1.0-alpha5 Marks an issue as being completely or in parts released in 8.1.0-alpha5 version:8.1.0 Marks an issue as being completely or in parts released in 8.1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants