-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reset method #10204
Remove reset method #10204
Conversation
On each process or onError call we will use a new ProcessingResultBuilder which means we no longer need to reset the ResultBuilder. Remove the reset from interface and the implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Zelldon
It's not clear to me how we can make this change now. Perhaps my assumptions are incorrect. Please have a look.
engine/src/main/java/io/camunda/zeebe/streamprocessor/ProcessingStateMachine.java
Show resolved
Hide resolved
@Zelldon Looks like you merged |
I dont see why this is an problem. BTW I used the github API. |
Rebasing to resolve conflicts in the branch makes the branch's history linear while merging with a merge commit leads to a split history. Linear history is easier to read. I thought that this was described in our CONTRIBUTING.md, but it states something that can't be correct:
I guess it means to say rebase the branch on top of IMO we should keep the history linear, but I'll leave it up to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bors r+ |
Build succeeded: |
Description
On each process or onError call we will use a new ProcessingResultBuilder which means we no longer need to reset the ResultBuilder.
Remove the reset from the interface and the implementation
Related issues
closes #10047
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3
) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.