Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reset method #10204

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Remove reset method #10204

merged 2 commits into from
Aug 30, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Aug 26, 2022

Description

On each process or onError call we will use a new ProcessingResultBuilder which means we no longer need to reset the ResultBuilder.
Remove the reset from the interface and the implementation

Related issues

closes #10047

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

On each process or onError call we will use a new ProcessingResultBuilder which means we no longer need to reset the ResultBuilder.
Remove the reset from interface and the implementation
@Zelldon Zelldon requested a review from korthout August 26, 2022 16:26
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022

Test Results

   853 files  ±    0     853 suites  ±0   1h 39m 33s ⏱️ + 1m 53s
6 665 tests +113  6 655 ✔️ +113  10 💤 ±0  0 ±0 
6 849 runs  +113  6 839 ✔️ +113  10 💤 ±0  0 ±0 

Results for commit 6e6523b. ± Comparison against base commit bbd0e5d.

♻️ This comment has been updated with latest results.

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zelldon

It's not clear to me how we can make this change now. Perhaps my assumptions are incorrect. Please have a look.

@Zelldon Zelldon requested a review from korthout August 30, 2022 06:21
@korthout
Copy link
Member

@Zelldon Looks like you merged main into this branch. Please rebase your branch on top of main instead.

@Zelldon
Copy link
Member Author

Zelldon commented Aug 30, 2022

I dont see why this is an problem. BTW I used the github API.

@korthout
Copy link
Member

I dont see why this is an problem

Rebasing to resolve conflicts in the branch makes the branch's history linear while merging with a merge commit leads to a split history. Linear history is easier to read.

I thought that this was described in our CONTRIBUTING.md, but it states something that can't be correct:

If there are merge conflicts the author of the pull request has to manually rebase main into the issue branch

I guess it means to say rebase the branch on top of main 🤷

IMO we should keep the history linear, but I'll leave it up to you.

Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Zelldon
Copy link
Member Author

Zelldon commented Aug 30, 2022

bors r+

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit c40bb29 into main Aug 30, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the zell-remove-reset branch August 30, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace direct reset with buffered writers
2 participants