Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse unary-tests expression with boolean and conjunction/disjunction #435

Merged
merged 4 commits into from
Jun 29, 2022
Merged

Parse unary-tests expression with boolean and conjunction/disjunction #435

merged 4 commits into from
Jun 29, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jun 15, 2022

Description

  • a unary-tests expression with a boolean literal and a conjunction/disjunction failed to parse
  • the parser expected no other chars (EOF) after the boolean literal was accepted
  • adjust the parser to accept the boolean literal only at the end of the expression (EOF)

Related issues

closes #429

@saig0
test: verify unary-tests with boolean conjunction/disjunction
9990208
@saig0
fix: parse unary-tests with conjunction/disjunction
7ef5c55 
* a unary-tests expression with a boolean literal and a conjunction/disjunction failed to parse
* the parser expected no other chars (EOF) after the boolean literal was accepted
* adjust the parser to accept the boolean literal only at the end of the expression (EOF)
@saig0 saig0 requested a review from korthout June 15, 2022 10:23
korthout
korthout requested changes Jun 23, 2022
View reviewed changes
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this correctly solves the issue, although that might just be my misunderstanding of the parser.

❌ Nevertheless, there is no test that shows that the regression is resolved.

src/test/scala/org/camunda/feel/impl/interpreter/InterpreterUnaryTest.scala Outdated Show resolved Hide resolved
src/main/scala/org/camunda/feel/impl/parser/FeelParser.scala Show resolved Hide resolved
@saig0 saig0 requested a review from korthout June 24, 2022 04:56
@saig0
Copy link
Member Author

saig0 commented Jun 24, 2022

@korthout please have another look. I added the missing test cases.

korthout
korthout requested changes Jun 24, 2022
View reviewed changes
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test cases

❌ Some of the cases don't reflect the documented behavior

src/test/scala/org/camunda/feel/impl/interpreter/InterpreterUnaryTest.scala Show resolved Hide resolved
@saig0 saig0 requested a review from korthout June 24, 2022 07:58
@saig0 saig0 merged commit ee8d47c into master Jun 29, 2022
@saig0 saig0 deleted the 429-unary-tests branch June 29, 2022 03:29
@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Merged
@github-actions
Copy link

Successfully created backport PR #438 for 1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korthout korthout korthout approved these changes

Assignees
No one assigned
Labels
backport 1.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Boolean Expressions: Parsing error when using Conjunction ("And") or Disjunction ("Or")
2 participants
@saig0 @korthout