Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return time with zone id/offset as OffsetTime #434

Merged
merged 4 commits into from Jun 20, 2022
Merged

Return time with zone id/offset as OffsetTime #434

merged 4 commits into from Jun 20, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jun 15, 2022

Description

  • return a time with zone id/offset as java.time.OffsetTime instead of custom ZonedTime

Related issues

closes #163

remcowesterhoud
remcowesterhoud approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@remcowesterhoud remcowesterhoud merged commit dfb2964 into master Jun 20, 2022
@remcowesterhoud remcowesterhoud deleted the 163-zoned-time branch June 20, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcowesterhoud remcowesterhoud remcowesterhoud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return a time value with zone-id as OffsetTime
2 participants
@saig0 @remcowesterhoud