Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose public getters of a POJO #423

Merged
merged 3 commits into from May 12, 2022
Merged

Expose public getters of a POJO #423

merged 3 commits into from May 12, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented May 6, 2022

Description

  • expose public getters of a POJO
  • the getter must be public and match to a field (i.e.getNameOfField() or isNameOfField())

Related issues

closes #360

@remcowesterhoud remcowesterhoud self-requested a review May 12, 2022 08:48
remcowesterhoud
remcowesterhoud approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good to see the refactoring at the end because I had a bunch of comments ready for this 😄

LGTM

@saig0 saig0 merged commit 0942599 into master May 12, 2022
@saig0 saig0 deleted the 360-pojo-public-getters branch May 12, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcowesterhoud remcowesterhoud remcowesterhoud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Public getters of POJOs are not exposed to custom functions
2 participants
@saig0 @remcowesterhoud