Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Builder-style method is used instead of getter #421

Merged
merged 2 commits into from May 4, 2022
Merged

Builder-style method is used instead of getter #421

merged 2 commits into from May 4, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented May 2, 2022

Description

  • an expression can access the properties of a bean via field or method lookup
  • ignore methods with parameters when resolving available fields of a bean

Related issues

closes #413

saig0 added 2 commits May 2, 2022 15:35
@saig0
test: verify field access with arguments
be2d1c4
@saig0
fix: ignore methods with parameters as fields
44c5712 
* an expression can access properties of a bean via field or method lookup
* ignore methods with arguments for field access
@saig0 saig0 requested a review from remcowesterhoud May 3, 2022 07:09
remcowesterhoud
remcowesterhoud approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@remcowesterhoud remcowesterhoud left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

💭 It's still kind of confusing when both getResult() and result() are defined. Would it be nice to always prefer getResult() over result() if available to keep some consistency, instead of letting it depend on the order they appear in the class?

@saig0
Copy link
Member Author

saig0 commented May 4, 2022

Would it be nice to always prefer getResult() over result() if available to keep some consistency, instead of letting it depend on the order they appear in the class?

Good point 👍
However, it is an edge case and not relevant for Camunda Platform 8. We don't have bean invocations in C8. So, I will leave it for now.

@saig0 saig0 merged commit 2c2d512 into master May 4, 2022
@saig0 saig0 deleted the 413-builder branch May 4, 2022 11:33
@github-actions github-actions bot mentioned this pull request May 4, 2022
Merged
@github-actions
Copy link

github-actions bot commented May 4, 2022

Successfully created backport PR #422 for 1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcowesterhoud remcowesterhoud remcowesterhoud approved these changes

Assignees
No one assigned
Labels
backport 1.14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Builder-style method is used instead of getter
2 participants
@saig0 @remcowesterhoud