Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression with conjunction/disjunction (and/or) fails if it contains parentheses #399

Merged
merged 1 commit into from Feb 9, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Feb 9, 2022

Description

  • add the reserved keywords: "and", "or" to avoid that a conjunction/disjunction is parsed as a function name
  • change the parsing behavior to avoid that a function name contains a reserved keyword like "and" / "or"
  • list all built-in function names with keywords explicitly because they don't match the regular function name anymore

Related issues

closes #397

@saig0 saig0 requested a review from tasso94 February 9, 2022 09:58
Copy link
Member

@tasso94 tasso94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🙂 👍

* add the reserved keywords: "and", "or"
* avoid that a conjunction/disjunction is parsed as function name
* change the parsing behavior to avoid that a function name contains a reserved keyword like "and"/"or"
@saig0 saig0 merged commit 5bd9a23 into master Feb 9, 2022
@saig0 saig0 deleted the 397-and-or branch February 9, 2022 10:31
@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Backport failed for 1.14, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin 1.14
git worktree add -d .worktree/backport-399-to-1.14 origin/1.14
cd .worktree/backport-399-to-1.14
git checkout -b backport-399-to-1.14
ancref=$(git merge-base 7d7092e074202234f10882abf25ad710cf937519 640a37cd1c549f5cae228d833a9878eb9f65535a)
git cherry-pick -x $ancref..640a37cd1c549f5cae228d833a9878eb9f65535a

@github-actions
Copy link

github-actions bot commented Feb 9, 2022

Successfully created backport PR #403 for 1.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression with conjunction/disjunction (and/or) fails if it contains parentheses
2 participants