Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): add satisfies, return, then, else as reserved keywords #395

Merged
merged 1 commit into from Feb 7, 2022

Conversation

tasso94
Copy link
Member

@tasso94 tasso94 commented Jan 27, 2022

Description

Add satisfies, return, then, else as reserved keywords.

Related issues

closes #394

@tasso94 tasso94 self-assigned this Jan 27, 2022
@tasso94 tasso94 changed the title fix(engine): add return, then, else as reserved keywords fix(engine): add satisfies, return, then, else as reserved keywords Jan 31, 2022
Adds `satisfies`, `return`, `then`, and `else` as reserved keywords.
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tasso94 looks good 👍

@tasso94
Copy link
Member Author

tasso94 commented Feb 4, 2022

Hi @saig0,

Thank you for your review.

I found out that and as well as or currently suffer under the same problem, and we should probably fix it as well. Unfortunately, adding these keywords to the list of reserved words leads to many failing test cases.

Best,
Tassilo

@saig0
Copy link
Member

saig0 commented Feb 4, 2022

@tasso94 nice finding 👍

Let me know if I should look into it or if we should look into it together 👀

@saig0
Copy link
Member

saig0 commented Feb 7, 2022

@tasso94 I created a new issue for expressions with and / or: #397. We see this issue now also in Zeebe 😅 I may take a look this week.

This PR seems to be ready. Can we merge it and backport it to 1.3.x?

@tasso94 tasso94 merged commit da3569a into master Feb 7, 2022
@tasso94 tasso94 deleted the 394-add-reserved-keywords branch February 7, 2022 13:51
@tasso94
Copy link
Member Author

tasso94 commented Feb 7, 2022

@saig0, I think we don't need to backport this since the only missing reserved keywords are return and satisfies. However, it works even without them on the list. This is probably related to the parser overhaul. Please let me know if I'm missing something here.

@saig0
Copy link
Member

saig0 commented Feb 8, 2022

@tasso94 true. I wanted to say that we should backport to branch 1.14.x 😅

@tasso94
Copy link
Member Author

tasso94 commented Feb 8, 2022

Got it! Will do 🙂👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation of expression keyword myVariable keyword myFunction() fails
2 participants