Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser) managing arbitrary names for a context key #388

Merged
merged 5 commits into from Jan 27, 2022

Conversation

ubaldop
Copy link
Contributor

@ubaldop ubaldop commented Jan 11, 2022

Description

  • introduces new parsing options for context key names

As you may notice, I slightly changed also the behavior of private def identifierWithWhitespaces[_: P]: P[String] since in previous version it supported only names with a single whitespace.

Related issues

closes #310

@ubaldop ubaldop changed the title Issue 310 fix(parser) managing arbitrary names for a context key Jan 11, 2022
@saig0 saig0 self-requested a review January 19, 2022 05:48
@saig0
Copy link
Member

saig0 commented Jan 19, 2022

@p3trur0 thank you for your contribution 🎉
I'll have a look soon 👀

I didn't expect this feature 😅 but one step forward the DMN spec 🚀

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p3trur0 the PR looks good 🎉
I like your changes 👍

I have one suggestion for the parser. Please have a look 🍪

@saig0 saig0 self-requested a review January 27, 2022 04:53
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p3trur0 thanks 👍 The PR is ready to merge 🚀

@saig0 saig0 merged commit d538afe into camunda:master Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can use arbitrary names for a context key
2 participants