Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine): list projection with variable #385

Merged
merged 1 commit into from Jan 4, 2022
Merged

fix(engine): list projection with variable #385

merged 1 commit into from Jan 4, 2022

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Jan 3, 2022

Description

  • fix path expression for list of contexts (i.e. list projection) with variable reference
    • reuse the existing logic of path expressions to avoid duplication and a difference in the behavior
  • it worked previously because it was parsed as a path expression instead of a ref expression

Related issues

closes #384

* fix path expression for list of contexts (i.e. list projection) with variable reference
* it worked previously because it was parsed as a `path` expression instead of a `ref` expression
@saig0 saig0 requested a review from korthout January 3, 2022 08:26
Copy link
Member

@korthout korthout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍄 Nice work!

@saig0 saig0 merged commit 1d3147f into master Jan 4, 2022
@saig0 saig0 deleted the 384-projection branch January 4, 2022 04:19
saig0 added a commit that referenced this pull request Jan 4, 2022
* fix path expression for list of contexts (i.e. list projection) with variable reference
* it worked previously because it was parsed as a `path` expression instead of a `ref` expression

(cherry picked from commit 1d3147f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to extract a property of a list of contexts (list projection)
2 participants