Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(interpreter): add a test for whitespaced named parameters #381

Merged
merged 3 commits into from Jan 5, 2022

Conversation

ubaldop
Copy link
Contributor

@ubaldop ubaldop commented Dec 30, 2021

Description

Please, mind that I build the test based on this. There, the function used is:

number(from: "1.000.000,01", decimal sep:",", grouping sep:".")

while in the codebase here the expected parameters names are:

  • from, decimal separator, grouping separator

Related issues

This tests the behavior expected by #311.

closes #311

@saig0 saig0 self-requested a review January 3, 2022 08:48
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p3trur0 thank you for providing the test case 👍

I have two minor comments. Please have a look 🍪

@ubaldop ubaldop requested a review from saig0 January 4, 2022 12:15
Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@p3trur0 nice 👍

@saig0 saig0 merged commit 4cd12fb into camunda:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can invoke a function with a named parameter that contains whitespaces
2 participants