Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(version-info): update release notes #3110

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Sep 1, 2022

Related to #3098

image

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Sep 1, 2022
@pinussilvestrus pinussilvestrus mentioned this pull request Sep 1, 2022
34 tasks
@pinussilvestrus pinussilvestrus force-pushed the 3098-update-release-notes branch 2 times, most recently from 9de2458 to 214f9a2 Compare September 6, 2022 07:47
@pinussilvestrus
Copy link
Contributor Author

Feel free to already give feedback 👍

@barmac
Copy link
Contributor

barmac commented Sep 6, 2022

Do you have a full changelog update anywhere? It would be helpful to provide feedback on this PR.

@pinussilvestrus
Copy link
Contributor Author

I didn't prepare the changelog yet, unfortunately. We agreed on these items recently (cf. https://camunda.slack.com/archives/GP70M0J6M/p1662020610527819).

Regarding the modeling improvements, I think you can also use the spring cleaning overview: https://github.com/bpmn-io/internal-docs/issues/607

@pinussilvestrus
Copy link
Contributor Author

@philippfromme
Copy link
Contributor

Generally, I don't think we have to include As of this release for every paragraph. It's implicit that it's about this release.

@philippfromme
Copy link
Contributor

philippfromme commented Sep 8, 2022

[...] are now sticky to provide reliable context. Shouldn't it be relevant context or something similar? What is unreliable context? Or do we mean reliably provide context as in isn't buggy anymore? 😆

Copy link
Contributor

@christian-konrad christian-konrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my small annotations

client/src/plugins/version-info/ReleaseInfo.js Outdated Show resolved Hide resolved
client/src/plugins/version-info/ReleaseInfo.js Outdated Show resolved Hide resolved
</li>
<li>
<h4>Sticky properties panel headers</h4>
The section headers of the BPMN and DMN properties panels are now sticky to provide reliable context.</li>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... to provide reliable context when you scroll.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@philippfromme reliable context means that users always now reliably in which group they are.

The section headers of the BPMN and DMN properties panels are now sticky to provide reliable context.</li>
<li>
<h4>Modeling UX improvements and bug fixes</h4>
This release includes a lot of modeling UX improvements. Sequence flows are now always displayed on top. Also, we fixed several issues to improve the copy and paste behavior.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually have a lot of improvements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say so, it includes almost everything from this list: https://github.com/bpmn-io/internal-docs/issues/607

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinussilvestrus Should we mention the improved XML/JSON editor in a own paragraph?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mh, I don't know whether this one is worth a mention. Technically we simply upgraded the Codemirror version, and the search bar now has a bit more functionality. But I don't know whether we want to promote this one at all.

Looking at the current snapshot, we already include a lot of stuff (especially compared to the last release notes).

image

It's mentioned in the Changelog.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@pinussilvestrus pinussilvestrus marked this pull request as ready for review September 8, 2022 09:55
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 8, 2022
@pinussilvestrus pinussilvestrus force-pushed the 3098-update-release-notes branch 2 times, most recently from 991c085 to ae28608 Compare September 8, 2022 10:26
@pinussilvestrus pinussilvestrus changed the base branch from develop to master September 8, 2022 13:17
@pinussilvestrus
Copy link
Contributor Author

As suggested by @christian-konrad I removed the C8 extension properties info as you can't select 8.1 as execution platform.

image

Copy link
Contributor

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@christian-konrad christian-konrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinussilvestrus pinussilvestrus merged commit 15784e9 into master Sep 9, 2022
@pinussilvestrus pinussilvestrus deleted the 3098-update-release-notes branch September 9, 2022 08:17
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants